Support kinesis and sqs config parameters in cloudwatch_event_target #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
service/cloudwatchevents
enhancement
bflad
reviewed
Apr 24, 2018
| partition_key_path = "$.detail" | ||
| } | ||
|
|
||
| depends_on = [ |
There was a problem hiding this comment.
The depends_on here is unnecessary since we already have explicit dependencies above 👍
| message_group_id = "event_group" | ||
| } | ||
|
|
||
| depends_on = [ |
There was a problem hiding this comment.
The depends_on here is unnecessary since we already have explicit dependencies above 👍
| EOF | ||
| } | ||
|
|
||
| resource "aws_kinesis_stream" "kinesis_stream" { |
There was a problem hiding this comment.
=== RUN TestAccAWSCloudWatchEventTarget_kinesis
--- FAIL: TestAccAWSCloudWatchEventTarget_kinesis (1.43s)
testing.go:518: Step 0 error: config is invalid: aws_kinesis_stream.kinesis_stream: "shard_count": required field is not set
| resource "aws_cloudwatch_event_target" "test" { | ||
| arn = "${aws_sqs_queue.sqs_queue.arn}" | ||
| rule = "${aws_cloudwatch_event_rule.cloudwatch_event_rule.id}" | ||
| role_arn = "${aws_iam_role.iam_role.arn}" |
There was a problem hiding this comment.
=== RUN TestAccAWSCloudWatchEventTarget_sqs
--- FAIL: TestAccAWSCloudWatchEventTarget_sqs (6.25s)
testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:
* aws_cloudwatch_event_target.test: 1 error(s) occurred:
* aws_cloudwatch_event_target.test: Creating CloudWatch Event Target failed: ValidationException: RoleArn is not supported for target arn:aws:sqs:us-west-2:*******:tf_sqs_target-8308111253966277394.fifo.
status code: 400, request id: 80962ecf-47c7-11e8-ad07-1f66da1224ee
bflad
approved these changes
Apr 24, 2018
There was a problem hiding this comment.
Great work, @gheine!
9 tests passed (all tests)
=== RUN TestAccAWSCloudWatchEventTarget_missingTargetId
--- PASS: TestAccAWSCloudWatchEventTarget_missingTargetId (7.04s)
=== RUN TestAccAWSCloudWatchEventTarget_sqs
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (7.16s)
=== RUN TestAccAWSCloudWatchEventTarget_ecs
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (10.53s)
=== RUN TestAccAWSCloudWatchEventTarget_ssmDocument
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (10.62s)
=== RUN TestAccAWSCloudWatchEventTarget_basic
--- PASS: TestAccAWSCloudWatchEventTarget_basic (12.19s)
=== RUN TestAccAWSCloudWatchEventTarget_input_transformer
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (25.01s)
=== RUN TestAccAWSCloudWatchEventTarget_kinesis
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (76.17s)
=== RUN TestAccAWSCloudWatchEventTarget_full
--- PASS: TestAccAWSCloudWatchEventTarget_full (76.67s)
=== RUN TestAccAWSCloudWatchEventTarget_batch
--- PASS: TestAccAWSCloudWatchEventTarget_batch (79.35s)
|
This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.