Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource aws_route53_zone - count fix #4341

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

pawelsocha
Copy link

This PR solves #562.

Add domain name to caller reference to avoid generate non-unique id.
Add test with count parameter in aws_route53_zone resource.

Test results:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSRoute53Zone_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSRoute53Zone_basic
--- PASS: TestAccAWSRoute53Zone_basic (167.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	167.460s

Manual tests:

Before:

* aws_route53_zone.test[2]: 1 error(s) occurred:

* aws_route53_zone.test.2: HostedZoneAlreadyExists: A hosted zone has already been created with the specified caller reference.
	status code: 409, request id: cd51d304-4882-11e8-9b8e-4dcc7a507192

After:

Apply complete! Resources: 10 added, 0 changed, 0 destroyed.

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 25, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/route53 Issues and PRs that pertain to the route53 service. labels Apr 25, 2018
@bflad bflad added this to the v1.17.0 milestone Apr 25, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @pawelsocha, thanks! 🚀

8 tests passed (all tests)
=== RUN   TestAccAWSRoute53Zone_importBasic
--- PASS: TestAccAWSRoute53Zone_importBasic (56.76s)
=== RUN   TestAccAWSRoute53Zone_updateComment
--- PASS: TestAccAWSRoute53Zone_updateComment (63.31s)
=== RUN   TestAccAWSRoute53Zone_private_basic
--- PASS: TestAccAWSRoute53Zone_private_basic (70.21s)
=== RUN   TestAccAWSRoute53Zone_private_region
--- PASS: TestAccAWSRoute53Zone_private_region (75.03s)
=== RUN   TestAccAWSRoute53ZoneAssociation_basic
--- PASS: TestAccAWSRoute53ZoneAssociation_basic (116.65s)
=== RUN   TestAccAWSRoute53Zone_basic
--- PASS: TestAccAWSRoute53Zone_basic (118.89s)
=== RUN   TestAccAWSRoute53ZoneAssociation_region
--- PASS: TestAccAWSRoute53ZoneAssociation_region (126.45s)
=== RUN   TestAccAWSRoute53Zone_forceDestroy
--- PASS: TestAccAWSRoute53Zone_forceDestroy (372.36s)

@bflad bflad merged commit 1981673 into hashicorp:master Apr 25, 2018
bflad added a commit that referenced this pull request Apr 25, 2018
@pawelsocha pawelsocha deleted the aws_route53_zone_count_fix branch April 26, 2018 08:37
@bflad
Copy link
Contributor

bflad commented May 2, 2018

This has been released in version 1.17.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants