Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_glue_job: Remove allocated_capacity and max_concurrent_runs upper plan time validation limits #4461

Merged
merged 1 commit into from
May 9, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 5, 2018

As correctly pointed out, these limits can be increased.

Closes #4331

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueJob'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueJob -timeout 120m
=== RUN   TestAccAWSGlueJob_Basic
--- PASS: TestAccAWSGlueJob_Basic (39.39s)
=== RUN   TestAccAWSGlueJob_AllocatedCapacity
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (33.50s)
=== RUN   TestAccAWSGlueJob_Command
--- PASS: TestAccAWSGlueJob_Command (81.33s)
=== RUN   TestAccAWSGlueJob_DefaultArguments
--- PASS: TestAccAWSGlueJob_DefaultArguments (21.49s)
=== RUN   TestAccAWSGlueJob_Description
--- PASS: TestAccAWSGlueJob_Description (22.92s)
=== RUN   TestAccAWSGlueJob_ExecutionProperty
--- PASS: TestAccAWSGlueJob_ExecutionProperty (21.05s)
=== RUN   TestAccAWSGlueJob_MaxRetries
--- PASS: TestAccAWSGlueJob_MaxRetries (21.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	241.541s

@bflad bflad added bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. labels May 5, 2018
@bflad bflad added this to the v1.18.0 milestone May 5, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 5, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 010ae80 into master May 9, 2018
@bflad bflad deleted the b-aws_glue_job-remove-validation branch May 9, 2018 20:00
bflad added a commit that referenced this pull request May 9, 2018
@bflad
Copy link
Contributor Author

bflad commented May 10, 2018

This has been released in version 1.18.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Remove hardcoded service limits on AWS Glue Jobs parameters
2 participants