Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure SQL as a DMS endpoint #4506

Merged
merged 1 commit into from
May 11, 2018

Conversation

microamp
Copy link
Contributor

Changes proposed in this pull request:

  • azuredb added to the list of engines supported in DMS
  • Documentation updated accordingly

Please see aws dms create-endpoint help, in particular its engine-name flag. No additional acceptance tests were added as it only depends on top-level attributes that are already present.

Thanks so much for reviewing.

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label May 11, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/databasemigrationservice labels May 11, 2018
@bflad bflad added this to the v1.19.0 milestone May 11, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @microamp! 🚀

Looks like we need s3 in the docs too, I'll update them after.

@bflad bflad merged commit 55a9f58 into hashicorp:master May 11, 2018
bflad added a commit that referenced this pull request May 11, 2018
@microamp
Copy link
Contributor Author

Looks like we need s3 in the docs too, I'll update them after.

Good catch! Thanks for doing that. 👏 I recall documenting it. I suspect it was removed accidentally when I was resolving merge conflicts before. 😥

@microamp microamp deleted the dms-endpoint-azuredb branch May 13, 2018 21:00
@bflad
Copy link
Contributor

bflad commented May 17, 2018

This has been released in version 1.19.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants