Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_guardduty_member: Support invite argument updates #4604

Merged
merged 1 commit into from
May 22, 2018
Merged

resource/aws_guardduty_member: Support invite argument updates #4604

merged 1 commit into from
May 22, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 22, 2018

Followup to #4357
Reference: #2489

Changes proposed in this pull request:

  • Support invite argument updates

Output from acceptance testing:

$ export AWS_GUARDDUTY_MEMBER_ACCOUNT_ID=...
$ export AWS_GUARDDUTY_MEMBER_EMAIL=...
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGuardDuty/Member'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGuardDuty/Member -timeout 120m
=== RUN   TestAccAWSGuardDuty
=== RUN   TestAccAWSGuardDuty/Member
=== RUN   TestAccAWSGuardDuty/Member/inviteOnUpdate
=== RUN   TestAccAWSGuardDuty/Member/inviteDisassociate
=== RUN   TestAccAWSGuardDuty/Member/invitationMessage
=== RUN   TestAccAWSGuardDuty/Member/basic
--- PASS: TestAccAWSGuardDuty (66.92s)
    --- PASS: TestAccAWSGuardDuty/Member (66.92s)
        --- PASS: TestAccAWSGuardDuty/Member/inviteOnUpdate (21.01s)
        --- PASS: TestAccAWSGuardDuty/Member/inviteDisassociate (20.57s)
        --- PASS: TestAccAWSGuardDuty/Member/invitationMessage (12.29s)
        --- PASS: TestAccAWSGuardDuty/Member/basic (13.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.959s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service. labels May 22, 2018
@bflad bflad requested a review from a team May 22, 2018 02:27
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label May 22, 2018
@bflad bflad mentioned this pull request May 22, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, otherwise LGTM 👍

aws/resource_aws_guardduty_member_test.go
detector_id = "${aws_guardduty_detector.test.id}"
disable_email_notification = true
email = "%[3]s"
invite = %[4]t
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by taking this approach (%[1]s vs %s) golint won't be able to determine if the types are wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really want to fix this upstream 😄

We should probably decide if we want to holistically go through all the test configurations and pick a format string style (indexed/unindexed) or use TF variables. Let's chat.

@bflad bflad added this to the v1.20.0 milestone May 22, 2018
@bflad bflad merged commit 91e800a into master May 22, 2018
@bflad bflad deleted the f-aws_guardduty_member-support-update branch May 22, 2018 14:17
bflad added a commit that referenced this pull request May 22, 2018
@bflad
Update CHANGELOG for #4604
121cedb
@bflad
Copy link
Contributor Author

bflad commented May 23, 2018

This has been released in version 1.20.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff