New Resource: aws_guardduty_invite_accepter

[bflad]

Closes #2489

Changes proposed in this pull request:

• Adds alternate AWS account handling in the provider acceptance testing framework
• Adds new resource for managing a GuardDuty member account invitation from a master account and disassociation from a master account

Output from acceptance testing:

    --- PASS: TestAccAWSGuardDuty/InviteAccepter (18.16s)
        --- PASS: TestAccAWSGuardDuty/InviteAccepter/basic (18.16s)

[connor-tyndall]

Are there any updates on this??

[bflad]

@connor-tyndall sorry for the delay with merging this resource. The work in progress note is fairly important for us to provide reliable and reproducible acceptance testing for this and other resource acceptance testing that works across multiple AWS accounts. There have been a few other priorities that have gotten in the way of focusing on finishing that up.

It'd be really helpful if folks could potentially try out a custom build of this branch and confirm it works as expected. There likely (although I can't promise) won't be any breaking changes to the resource itself to get it merged.

[brandonstevens]

@bflad I've successfully reproduced the test results against a couple of test AWS Accounts at my disposal. I tested the original branch as well as a rebased branch (after fixing a trivial conflict). Let me know how I can further help as we're looking forward to leveraging this resource to roll out GuardDuty to our numerous accounts.

 make testacc TEST=./aws TESTARGS='-run=TestAccAWSGuardDuty/InviteAccepter'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSGuardDuty/InviteAccepter -timeout 120m
=== RUN   TestAccAWSGuardDuty
=== RUN   TestAccAWSGuardDuty/InviteAccepter
=== RUN   TestAccAWSGuardDuty/InviteAccepter/basic
--- FAIL: TestAccAWSGuardDuty (9.29s)
    --- FAIL: TestAccAWSGuardDuty/InviteAccepter (9.29s)
        --- FAIL: TestAccAWSGuardDuty/InviteAccepter/basic (9.29s)
            testing.go:538: Step 0 error: Check failed: Check 1/3 error: Not found: aws_guardduty_invite_accepter.test
            testing.go:599: Error destroying resource! WARNING: Dangling resources
                may exist. The full state and error is shown below.

                Error: config is invalid: aws_guardduty_invite_accepter.member: configuration for provider.aws.alternate is not present; a provider configuration block is required for all operations

                State: <nil>
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	9.333s
make: *** [testacc] Error 1

[JoshiiSinfield]

Hi @bflad ,

Has there been any movement on this, & #2489 ?

Cheers,
Josh

[nywilken]

One minor nit but otherwise good to go. Nicely Done 👍

[nywilken]

Suggested change

	invitationID := ""
	var invitationID string

var is preferred when declaring and initializing a variable to its zero value

[bflad]

This has been released in version 2.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!