Add app sync schema #4840

beauknowssoftware · 2018-06-14T17:56:57Z

Changes proposed in this pull request:

Add AppSync Schema resource
Add documentation for AppSync Schema resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsAppsyncSchema'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAwsAppsyncSchema -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsAppsyncSchema
--- PASS: TestAccAwsAppsyncSchema (19.28s)
=== RUN   TestAccAwsAppsyncSchema_update
--- PASS: TestAccAwsAppsyncSchema_update (33.94s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       (cached)
...

Aedalus · 2018-06-15T18:35:21Z

I could really use appsync schemas and resolvers for a current project! I'd love to see this get in.

beauknowssoftware · 2018-07-26T23:09:13Z

@bflad Is there anything more I need to do with this to get it pulled in?

sconzof · 2018-08-16T18:06:19Z

Looks like the travis CI checks passed. I would LOVE to use terraform exclusively for my schema updates, rather than a hybrid where I do some parts of AppSync with TF and must do the remainder with CF. I hope this gets added soon!

macbutch · 2018-08-16T23:20:13Z

Wow! This will make my life so much better when it lands - hope it can be soon too! (@phuonglu)

simenandre · 2018-08-17T19:26:51Z

+1 from me. We really need this for our Terraform setup. 👍

ehubbard · 2018-08-20T15:47:07Z

+1 from me 👍

bflad · 2018-08-20T16:13:38Z

Hi folks 👋 Please note that we can only utilize 👍 upvote reactions to the original issue or pull request for reporting and prioritization. e.g. https://github.com/terraform-providers/terraform-provider-aws/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc "+1"/"me too" comments unfortunately only generate noise for issue/pull request followers and do not help the maintainers with prioritization. 😅

ghost · 2018-08-21T11:13:56Z

👍 upvote +1

plainsane · 2018-08-21T11:22:11Z

Yea, this would be nice, it’s pretty bobo to have to shell out to,get this done

sleerssen · 2018-08-21T12:41:23Z

yes, please

praveenc1 · 2018-08-21T14:54:23Z

+1. Like to see this implemented.

clearly · 2018-08-21T15:36:38Z

+1.This really needs to be added.

eugene-manuilov · 2018-09-10T20:45:42Z

@beauknowssoftware, perhaps it would be easier if you extract your changes to be a separate plugin? In this case, we won't need to wait for ages till it gets merged into master...

perryao · 2018-09-11T17:55:23Z

aws/resource_aws_appsync_schema.go

+			return err
+		}
+
+		if err := waitForSchemaToBeActive(apiId, meta); err != nil {


@beauknowssoftware I've been working on implementing AppSync resolvers and came across your PR via #2705 . I'm wondering if this wait could be implemented using StateChangeConf provided in terraform/helper/resource. Here's an example in CloudFormation stacks: https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_cloudformation_stack.go#L178. I believe it can since there are discrete statuses returned from GetSchemaCreationStatus

I will agree with @perryao here -- we tend to prefer API waiting via existing SDK Waiter functions (pretty rare), resource.Retry(), or resource.StateChangeConf: https://www.terraform.io/docs/extend/resources.html#statechangeconf

There are quite a few examples across the project if you search for StateChangeConf, but I can certainly help if you need specific guidance. 😄

garrett-hopper · 2018-09-12T21:50:37Z

Does this include resolver configuration or just the schema?

dguisinger · 2018-10-10T02:13:20Z

Any progress on this? AppSync has been in general availability for 10 months ....

eugene-manuilov · 2018-10-10T06:07:56Z

As a workaround, I use cloudformation to define schema and resolvers for now. Hope it helps to someone who also waits for this PR to be merged.

bflad

Hi @beauknowssoftware 👋 Thanks for submitting this and sorry for the delays in getting it reviewed. 😅 I left some initial questions and feedback below. Please reach out with any questions or let us know if you do not have time to continue working on this.

bflad · 2018-10-12T20:05:56Z

aws/resource_aws_appsync_schema.go

+func resourceAwsAppsyncSchema() *schema.Resource {
+	return &schema.Resource{
+		Create: resourceAwsAppsyncSchemaPut,
+		Read:   resourceAwsAppsyncSchemaNil,


Is it possible to read this information via the GetIntrospectionSchema API call? One of Terraform's design tenets is that it can detect configuration drift. If its not possible to read this information back from the API, this may not be a good candidate for management in Terraform.

The introspection schema is not the same blob that is sent to StartSchemaCreation. These are two different objects. Schema must be present in order to create resolvers. Setting up the schema outside of Terraform would mean either setting up the API outside of Terraform before hand or setting up resolvers outside of Terraform afterwards. Neither of these options is ideal.

bflad · 2018-10-12T20:07:52Z

aws/provider.go

@@ -309,6 +309,7 @@ func Provider() terraform.ResourceProvider {
 			"aws_appsync_api_key":                              resourceAwsAppsyncApiKey(),
 			"aws_appsync_datasource":                           resourceAwsAppsyncDatasource(),
 			"aws_appsync_graphql_api":                          resourceAwsAppsyncGraphqlApi(),
+			"aws_appsync_schema":                               resourceAwsAppsyncSchema(),


Can a AppSync Graph API have more than one schema? If not, instead of a new resource, it may make better sense as an attribute of the existing aws_appsync_graphql_api resource (unless self-references are necessary).

There is only one schema per API. I can look into adding it as an attribute instead of a separate resource. This would move my StartSchemaCreation logic into the API create/update methods.

bflad · 2018-10-12T20:10:03Z

aws/resource_aws_appsync_schema.go

+			return err
+		}
+
+		if err := waitForSchemaToBeActive(apiId, meta); err != nil {


I will agree with @perryao here -- we tend to prefer API waiting via existing SDK Waiter functions (pretty rare), resource.Retry(), or resource.StateChangeConf: https://www.terraform.io/docs/extend/resources.html#statechangeconf

There are quite a few examples across the project if you search for StateChangeConf, but I can certainly help if you need specific guidance. 😄

bflad · 2018-10-12T20:22:26Z

aws/resource_aws_appsync_schema.go

+		Create: resourceAwsAppsyncSchemaPut,
+		Read:   resourceAwsAppsyncSchemaNil,
+		Update: resourceAwsAppsyncSchemaPut,
+		Delete: resourceAwsAppsyncSchemaNil,


Not having a deletion method may be another sign that this may not make sense as its own resource, but instead an attribute of an existing "parent" resource (aws_appsync_graphql_api). 👍 Otherwise, we should use schema.Noop instead of our own function here and add a warning to the documentation that removing this resource does not actually delete the schema.

bflad · 2018-10-12T20:23:01Z

aws/resource_aws_appsync_schema.go

+		Delete: resourceAwsAppsyncSchemaNil,
+
+		Schema: map[string]*schema.Schema{
+			"api_id": &schema.Schema{


This attribute should be ForceNew: true since this field is not update-able.

bflad · 2018-10-12T20:25:47Z

aws/resource_aws_appsync_schema.go

+	if d.HasChange("definition") {
+		input := &appsync.StartSchemaCreationInput{
+			ApiId:      aws.String(apiId),
+			Definition: ([]byte)(d.Get("definition").(string)),


Since this attribute is []byte, do we need to worry about actual binary data? Terraform's state currently requires UTF-8 compatibility otherwise it could cause corruption.

tejans24 · 2018-11-07T14:48:37Z

has @beauknowssoftware gone MIA? Is this still in-progress? Just curious, thanks for working on this.

beauknowssoftware · 2018-11-08T14:27:45Z

Sorry for the late response to this thread. I haven't forgotten about this PR, but I also haven't had time to get back to work on it. Hoping to have more spare time over the holidays

ngocketit · 2019-01-08T12:54:00Z

+1 for this please.

barundel · 2019-01-09T14:47:12Z

hey @beauknowssoftware any chance of an update? cheers for your work so far ;)

beauknowssoftware · 2019-01-14T19:42:23Z

@bflad
I think this is ready for another look. Please let me know if there are any other changes that need to be made

beauknowssoftware · 2019-01-15T17:47:58Z

TF_ACC=1 go test ./... -v -parallel 20 -run="AccAWSAppsyncGraphqlApi_basic" -timeout 120m
? github.com/terraform-providers/terraform-provider-aws [no test files]
=== RUN TestAccAWSAppsyncGraphqlApi_basic
=== PAUSE TestAccAWSAppsyncGraphqlApi_basic
=== CONT TestAccAWSAppsyncGraphqlApi_basic
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (6.97s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 6.992s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run="AccAWSAppsyncGraphqlApi_schema" -timeout 120m
? github.com/terraform-providers/terraform-provider-aws [no test files]
=== RUN TestAccAWSAppsyncGraphqlApi_schema
=== PAUSE TestAccAWSAppsyncGraphqlApi_schema
=== CONT TestAccAWSAppsyncGraphqlApi_schema
--- PASS: TestAccAWSAppsyncGraphqlApi_schema (17.15s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 17.168s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run="AccAWSAppsyncGraphqlApi_Authentication" -timeout 120m
? github.com/terraform-providers/terraform-provider-aws [no test files]
=== RUN TestAccAWSAppsyncGraphqlApi_AuthenticationType
=== PAUSE TestAccAWSAppsyncGraphqlApi_AuthenticationType
=== RUN TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey
=== PAUSE TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey
=== RUN TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM
=== PAUSE TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM
=== RUN TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools
=== PAUSE TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools
=== RUN TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect
=== PAUSE TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect
=== CONT TestAccAWSAppsyncGraphqlApi_AuthenticationType
=== CONT TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect
=== CONT TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools
=== CONT TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM
=== CONT TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (6.14s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (6.52s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (7.53s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (9.36s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (10.59s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 10.621s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run="AccAWSAppsyncGraphqlApi_LogConfig" -timeout 120m
? github.com/terraform-providers/terraform-provider-aws [no test files]
=== RUN TestAccAWSAppsyncGraphqlApi_LogConfig
=== PAUSE TestAccAWSAppsyncGraphqlApi_LogConfig
=== RUN TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel
=== PAUSE TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel
=== CONT TestAccAWSAppsyncGraphqlApi_LogConfig
=== CONT TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (6.91s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (16.96s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 16.982s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run="AccAWSAppsyncGraphqlApi_OpenIDConnectConfig" -timeout 120m
? github.com/terraform-providers/terraform-provider-aws [no test files]
=== RUN TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL
=== PAUSE TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL
=== RUN TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID
=== PAUSE TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID
=== RUN TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL
=== PAUSE TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL
=== RUN TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer
=== PAUSE TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer
=== CONT TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL
=== CONT TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer
=== CONT TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL
=== CONT TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (9.96s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (9.97s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (10.00s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (10.02s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 10.038s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run="AccAWSAppsyncGraphqlApi_Name" -timeout 120m
? github.com/terraform-providers/terraform-provider-aws [no test files]
=== RUN TestAccAWSAppsyncGraphqlApi_Name
=== PAUSE TestAccAWSAppsyncGraphqlApi_Name
=== CONT TestAccAWSAppsyncGraphqlApi_Name
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (9.17s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 9.189s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run="AccAWSAppsyncGraphqlApi_UserPoolConfig" -timeout 120m
? github.com/terraform-providers/terraform-provider-aws [no test files]
=== RUN TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion
=== PAUSE TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion
=== RUN TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction
=== PAUSE TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction
=== CONT TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion
=== CONT TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (11.78s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (13.11s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 13.129s

This reverts commit a85a7c2.

bflad

Thanks so much @beauknowssoftware for the updates. 🚀 I left some minor feedback items below -- some of which are being addressed on merge in a followup commit and others in the followup #6451 pull request which builds on this work here. Thanks again.

Output from acceptance testing:

--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (11.52s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (11.59s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (12.23s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (12.81s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (13.28s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (13.38s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (15.68s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (17.19s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (17.31s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (19.40s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (19.53s)
--- PASS: TestAccAWSAppsyncGraphqlApi_schema (22.54s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (22.98s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (23.53s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (25.50s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (27.44s)

bflad · 2019-03-26T19:10:47Z

aws/resource_aws_appsync_graphql_api.go

@@ -159,6 +165,11 @@ func resourceAwsAppsyncGraphqlApiCreate(d *schema.ResourceData, meta interface{}
 		return err
 	}

+	err = resourceAwsAppsyncSchemaPut(*resp.GraphqlApi.ApiId, d, meta)


This handling should be removed below the d.SetId() call so Terraform does not lose track of the AppSync GraphQL API resource if this errors.

bflad · 2019-03-26T19:10:56Z

aws/resource_aws_appsync_graphql_api.go

@@ -159,6 +165,11 @@ func resourceAwsAppsyncGraphqlApiCreate(d *schema.ResourceData, meta interface{}
 		return err
 	}

+	err = resourceAwsAppsyncSchemaPut(*resp.GraphqlApi.ApiId, d, meta)
+	if err != nil {
+		return err


We should return error context here for operators and code maintainers:

Suggested change

return err

return fmt.Errorf("error creating AppSync GraphQL API (%s) Schema: %s", d.Id(), err)

bflad · 2019-03-26T19:11:08Z

aws/resource_aws_appsync_graphql_api.go

@@ -230,6 +241,11 @@ func resourceAwsAppsyncGraphqlApiUpdate(d *schema.ResourceData, meta interface{}
 		return err
 	}

+	err = resourceAwsAppsyncSchemaPut(d.Id(), d, meta)
+	if err != nil {
+		return err


We should return error context here for operators and code maintainers:

Suggested change

return err

return fmt.Errorf("error updating AppSync GraphQL API (%s) Schema: %s", d.Id(), err)

bflad · 2019-03-26T19:12:11Z

aws/resource_aws_appsync_graphql_api.go

+		}
+
+		activeSchemaConfig := &resource.StateChangeConf{
+			Pending: []string{"PROCESSING"},


Nit: We should use the AWS Go SDK provided constants here and below, e.g.

Suggested change

Pending: []string{"PROCESSING"},

Pending: []string{appsync.SchemaStatusProcessing},

bflad · 2019-03-26T19:13:26Z

aws/resource_aws_appsync_graphql_api_test.go

+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckAwsAppsyncGraphqlApiDestroy,
+		Steps: []resource.TestStep{


Since the new attribute is not marked ForceNew: true an additional TestStep should be included to ensure updates occur correctly.

bflad · 2019-03-26T19:14:00Z

website/docs/r/appsync_graphql_api.html.markdown

@@ -104,6 +120,7 @@ The following arguments are supported:
 * `log_config` - (Optional) Nested argument containing logging configuration. Defined below.
 * `openid_connect_config` - (Optional) Nested argument containing OpenID Connect configuration. Defined below.
 * `user_pool_config` - (Optional) The Amazon Cognito User Pool configuration. Defined below.
+* `schema` - (Required) The schema definition, in GraphQL schema language format


Suggested change

* `schema` - (Required) The schema definition, in GraphQL schema language format

* `schema` - (Optional) The schema definition, in GraphQL schema language format. Terraform cannot perform drift detection of this configuration.

Output from acceptance testing: ``` --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (11.52s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (11.59s) --- PASS: TestAccAWSAppsyncGraphqlApi_basic (12.23s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (12.81s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (13.28s) --- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (13.38s) --- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (15.68s) --- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (17.19s) --- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (17.31s) --- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (19.40s) --- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (19.53s) --- PASS: TestAccAWSAppsyncGraphqlApi_schema (22.54s) --- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (22.98s) --- PASS: TestAccAWSAppsyncGraphqlApi_Name (23.53s) --- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (25.50s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (27.44s) ```

bflad · 2019-03-29T06:37:19Z

This has been released in version 2.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-03-30T17:58:06Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added the size/L Managed by automation to categorize the size of a PR. label Jun 14, 2018

bflad added new-resource Introduces a new resource. service/appsync Issues and PRs that pertain to the appsync service. labels Jun 15, 2018

ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 9, 2018

beauknowssoftware mentioned this pull request Aug 16, 2018

AppSync resource proposal #2705

Closed

perryao reviewed Sep 11, 2018

View reviewed changes

bflad reviewed Oct 12, 2018

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 12, 2018

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 8, 2019

ghost added the documentation Introduces or discusses updates to documentation. label Jan 13, 2019

beauknowssoftware force-pushed the appsync_graphql_api branch from 7bfbaf5 to 433afcf Compare January 14, 2019 18:25

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 14, 2019

beauknowssoftware force-pushed the appsync_graphql_api branch 2 times, most recently from c9f7276 to 492ada1 Compare January 14, 2019 18:34

beauknowssoftware added 2 commits January 14, 2019 13:39

Move appsync schema into appsync graphql api

74448e4

Add appsync schema test

02fddb7

beauknowssoftware force-pushed the appsync_graphql_api branch from 492ada1 to 078d9a6 Compare January 14, 2019 18:39

ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 14, 2019

beauknowssoftware force-pushed the appsync_graphql_api branch from 078d9a6 to 3a4927b Compare January 14, 2019 19:01

Format

666077b

beauknowssoftware force-pushed the appsync_graphql_api branch from 3a4927b to 666077b Compare January 14, 2019 19:05

Do not require profile for tests

a85a7c2

beauknowssoftware force-pushed the appsync_graphql_api branch from a85a7c2 to 666077b Compare January 15, 2019 17:47

Revert "Do not require profile for tests"

cf3a3b1

This reverts commit a85a7c2.

bflad mentioned this pull request Mar 14, 2019

Added support for appsync_graphql_api schema dn appsync_resolver #6451

Merged

bflad added this to the v2.4.0 milestone Mar 26, 2019

bflad self-requested a review March 26, 2019 18:57

bflad approved these changes Mar 26, 2019

View reviewed changes

bflad merged commit cf3a3b1 into hashicorp:master Mar 26, 2019

bflad added a commit that referenced this pull request Mar 26, 2019

Update CHANGELOG for #4840

4254a9c

ghost locked and limited conversation to collaborators Mar 30, 2020

	return err
	return fmt.Errorf("error creating AppSync GraphQL API (%s) Schema: %s", d.Id(), err)

	return err
	return fmt.Errorf("error updating AppSync GraphQL API (%s) Schema: %s", d.Id(), err)

	Pending: []string{"PROCESSING"},
	Pending: []string{appsync.SchemaStatusProcessing},

	* `schema` - (Required) The schema definition, in GraphQL schema language format
	* `schema` - (Optional) The schema definition, in GraphQL schema language format. Terraform cannot perform drift detection of this configuration.

Add app sync schema #4840

Add app sync schema #4840

Conversation

beauknowssoftware commented Jun 14, 2018

Aedalus commented Jun 15, 2018

beauknowssoftware commented Jul 26, 2018

sconzof commented Aug 16, 2018

macbutch commented Aug 16, 2018

simenandre commented Aug 17, 2018

ehubbard commented Aug 20, 2018

bflad commented Aug 20, 2018 • edited Loading

ghost commented Aug 21, 2018

plainsane commented Aug 21, 2018

sleerssen commented Aug 21, 2018

praveenc1 commented Aug 21, 2018

clearly commented Aug 21, 2018

eugene-manuilov commented Sep 10, 2018

Choose a reason for hiding this comment

bflad Oct 12, 2018 • edited Loading

Choose a reason for hiding this comment

garrett-hopper commented Sep 12, 2018

dguisinger commented Oct 10, 2018

eugene-manuilov commented Oct 10, 2018

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bflad Oct 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tejans24 commented Nov 7, 2018 • edited Loading

beauknowssoftware commented Nov 8, 2018

ngocketit commented Jan 8, 2019

barundel commented Jan 9, 2019

beauknowssoftware commented Jan 14, 2019

beauknowssoftware commented Jan 15, 2019

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bflad commented Mar 29, 2019

ghost commented Mar 30, 2020

bflad commented Aug 20, 2018 •

edited

Loading

bflad Oct 12, 2018 •

edited

Loading

bflad Oct 12, 2018 •

edited

Loading

tejans24 commented Nov 7, 2018 •

edited

Loading