Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_neptune_parameter_group: Support tags argument and arn attribute #4873

Merged
merged 2 commits into from
Jun 19, 2018
Merged

resource/aws_neptune_parameter_group: Support tags argument and arn attribute #4873

merged 2 commits into from
Jun 19, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 18, 2018

Reference: #4713

Changes proposed in this pull request:

  • Add arn attribute to aws_neptune_parameter_group resource
  • Add tags argument to aws_neptune_parameter_group resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNeptuneParameterGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSNeptuneParameterGroup -timeout 120m
=== RUN   TestAccAWSNeptuneParameterGroup_basic
--- PASS: TestAccAWSNeptuneParameterGroup_basic (15.80s)
=== RUN   TestAccAWSNeptuneParameterGroup_Description
--- PASS: TestAccAWSNeptuneParameterGroup_Description (14.66s)
=== RUN   TestAccAWSNeptuneParameterGroup_Parameter
--- PASS: TestAccAWSNeptuneParameterGroup_Parameter (27.16s)
=== RUN   TestAccAWSNeptuneParameterGroup_Tags
--- PASS: TestAccAWSNeptuneParameterGroup_Tags (34.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	92.509s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/neptune Issues and PRs that pertain to the neptune service. labels Jun 18, 2018
@bflad bflad added this to the v1.24.0 milestone Jun 18, 2018
@bflad bflad requested a review from a team June 18, 2018 19:55
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jun 18, 2018
tombuildsstuff
tombuildsstuff approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

aws/resource_aws_neptune_parameter_group_test.go Outdated

tags {
%s = "%s"
%s = "%s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really minor the second "%s" can become %q here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 updated all "%s" references to %q in 911d32b and acceptance testing passes as expected:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSNeptuneParameterGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSNeptuneParameterGroup -timeout 120m
=== RUN   TestAccAWSNeptuneParameterGroup_basic
--- PASS: TestAccAWSNeptuneParameterGroup_basic (17.16s)
=== RUN   TestAccAWSNeptuneParameterGroup_Description
--- PASS: TestAccAWSNeptuneParameterGroup_Description (16.61s)
=== RUN   TestAccAWSNeptuneParameterGroup_Parameter
--- PASS: TestAccAWSNeptuneParameterGroup_Parameter (28.50s)
=== RUN   TestAccAWSNeptuneParameterGroup_Tags
--- PASS: TestAccAWSNeptuneParameterGroup_Tags (36.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	99.213s

@bflad bflad merged commit 3f0a071 into master Jun 19, 2018
@bflad bflad deleted the f-aws_neptune_parameter_group-tags branch June 19, 2018 13:38
bflad added a commit that referenced this pull request Jun 19, 2018
@bflad
Update CHANGELOG for #4873
e560ef2
darrenhaken pushed a commit to darrenhaken/terraform-provider-aws that referenced this pull request Jun 20, 2018
@bflad @darrenhaken
Update CHANGELOG for hashicorp#4873
a8e0dc2
@bflad
Copy link
Contributor Author

bflad commented Jun 25, 2018

This has been released in version 1.24.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/neptune Issues and PRs that pertain to the neptune service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff