New Data Source: aws_vpc_dhcp_options

[bflad]

The existing resource and upstream API are unfortunately pluralized, so to reduce confusion, kept the pluralized naming for the data source as well.

Fixes #1395

Changes proposed in this pull request:

• New Data Source: aws_vpc_dhcp_options

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsVpcDhcpOptions_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsVpcDhcpOptions_basic -timeout 120m
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_basic
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (14.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.036s

[mbfrahry]

LGTM

[bflad]

Hey @mbfrahry -- sorry for the additional commit, I realized the OSS issue was specifically asking for support for EC2 filtering, while the Asana was for just for the DHCP Options ID. I added in the support and its still passing acceptance testing.

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsVpcDhcpOptions'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsVpcDhcpOptions -timeout 120m
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_basic
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (14.23s)
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (12.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.621s

[paultyng]

Maybe add a non-matching options set here to ensure this isn't just getting lucky with the 1?

[bflad]

@paultyng I've added testing in 1ea1b80 for:

• no matches
• multiple matches
• incorrect matching

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsVpcDhcpOptions'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsVpcDhcpOptions -timeout 120m
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_basic
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (15.40s)
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (17.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.649s

[bflad]

This has been released in version 1.24.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!