Adds support for PRIVATE endpoint type for aws_api_gateway_rest_api

[edsonmarquezani]

Changes proposed in this pull request:

• Adds support for private API Gateways[1]

[1] https://aws.amazon.com/blogs/compute/introducing-amazon-api-gateway-private-endpoints/

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayRestApi_EndpointConfiguration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSAPIGatewayRestApi_EndpointConfiguration -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSAPIGatewayRestApi_EndpointConfiguration
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (136.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	136.921s
...

Comments

My Golang knowledge is vey limited, but instead of asking for this feature, I thought I could do it myself and contribute. The change is quite simple, yet I'm not sure the acceptance test I added is correct. Please tell me if not.
I built and tested it and it works.

[bflad]

Hi @edsonmarquezani, thanks for submitting this! 🚀

As detailed below, I will go ahead and make the more advanced testing adjustments in a commit after yours so we can get this released today and continue to support GovCloud (US) testing with this resource.

[bflad]

We generally prefer to create whole new top level acceptance test functions instead of adding multiple resource.Test() within the same function -- this allows us to parallelize our testing better. 😄

Another complicated piece to our API Gateway testing here is that we run the service testing across multiple AWS partitions (Commercial and GovCloud (US)), which the latter may or may not support the new PRIVATE REST API endpoint type. If you look at the TestStep above your addition here, we have a PreConfig function that ensures the AWS API Gateway service its calling supports the EDGE endpoint type or skips the rest of the test. We'll want to add something similar for PRIVATE as well.

Do not be discouraged here though! There just happens to be more advanced testing handling with this resource testing than other parts of our resource testing. You actually were on the right track except the tweaks mentioned above, which I can handle in a commit after yours to expedite releasing this enhancement for everyone. 👍

[edsonmarquezani]

Ok, I get it. I just didn't know private type might not be supported in some regions.

As for the remaing, I understand you're going to make the adjustments yourself, right? Anyway, feel free to ask for it, if you want to. I think I could handle it. ;)

[bflad]

This has been released in version 1.24.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!