Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/aws_rds_cluster: Prevent panic when CloudWatch logs are enabled #4927

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 21, 2018

Fixes #4922

While I can add an acceptance test to cover this specific case, it does bring up an interesting point. This data source failure would only occur in a certain resource situation and was not caught by existing acceptance testing. Much like we can run into trouble if all acceptance testing doesn't run the ImportStateVerify check for all iterations of a resource, we can run into similar situations with data sources as well. Thoughts appreciated on future thinking about how to handle this better.

Changes proposed in this pull request:

  • Add enabled_cloudwatch_logs_exports attribute to aws_rds_cluster data source to match resource

Output from acceptance testing:

1 test passed (all tests)
=== RUN   TestAccDataSourceAwsRdsCluster_basic
--- PASS: TestAccDataSourceAwsRdsCluster_basic (103.40s)

@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/rds Issues and PRs that pertain to the rds service. labels Jun 21, 2018
@bflad bflad added this to the v1.25.0 milestone Jun 21, 2018
@bflad bflad requested a review from a team June 21, 2018 14:03
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jun 21, 2018
@bflad bflad merged commit 0fd3b69 into master Jun 22, 2018
@bflad bflad deleted the b-aws_rds_cluster-ds-cloudwatch-panic branch June 22, 2018 12:58
bflad added a commit that referenced this pull request Jun 22, 2018
@bflad
Copy link
Contributor Author

bflad commented Jun 27, 2018

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants