data-source/aws_rds_cluster: Prevent panic when CloudWatch logs are enabled #4927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4922
While I can add an acceptance test to cover this specific case, it does bring up an interesting point. This data source failure would only occur in a certain resource situation and was not caught by existing acceptance testing. Much like we can run into trouble if all acceptance testing doesn't run the
ImportStateVerify
check for all iterations of a resource, we can run into similar situations with data sources as well. Thoughts appreciated on future thinking about how to handle this better.Changes proposed in this pull request:
enabled_cloudwatch_logs_exports
attribute toaws_rds_cluster
data source to match resourceOutput from acceptance testing: