Issue #4260 New datasource: aws_network_acls

[saravanan30erd]

Fixes #4260

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsNetworkAcls_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccDataSourceAwsNetworkAcls_basic -timeout 120m
=== RUN   TestAccDataSourceAwsNetworkAcls_basic
--- PASS: TestAccDataSourceAwsNetworkAcls_basic (145.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	145.279s
...

[bflad]

This parameter does not look required for the API call and its valid to want to search for Network ACLs across multiple VPCs, so it should be made optional or removed (in preference of filter): https://docs.aws.amazon.com/sdk-for-go/api/service/ec2/#DescribeNetworkAclsInput

[bflad]

Thanks for getting this in @saravanan30erd! There was one issue where d.SetId() was still referencing d.Get("vpc_id").(string) which could be "" when not defined, so took the liberty to switch that resource.UniqueId() and ensured the testing would have caught that scenario that so we can get this merged and released this week. You rock! 👍

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsNetworkAcls'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsNetworkAcls -timeout 120m
=== RUN   TestAccDataSourceAwsNetworkAcls_basic
--- PASS: TestAccDataSourceAwsNetworkAcls_basic (38.42s)
=== RUN   TestAccDataSourceAwsNetworkAcls_Filter
--- PASS: TestAccDataSourceAwsNetworkAcls_Filter (27.23s)
=== RUN   TestAccDataSourceAwsNetworkAcls_Tags
--- PASS: TestAccDataSourceAwsNetworkAcls_Tags (26.88s)
=== RUN   TestAccDataSourceAwsNetworkAcls_VpcID
--- PASS: TestAccDataSourceAwsNetworkAcls_VpcID (27.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	119.800s

[bflad]

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!