add association type for aws_wafregional_web_acl rules

[svenwltr]

Fixes #4184

Changes proposed in this pull request:

• add type field for aws_wafregional_web_acl, so it supports aws_wafregional_rate_based_rule resources

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalWebAcl_createRateBased'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSWafRegionalWebAcl_createRateBased -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalWebAcl_createRateBased
--- PASS: TestAccAWSWafRegionalWebAcl_createRateBased (20.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	(cached)
...

I would really like to add a check for the type attribute, but I don't know how to figure out the hash (xxx in the example below).

resource.TestCheckResourceAttr(
	"aws_wafregional_web_acl.waf_acl", "rule.xxx.type", "RATE_BASED"),

[bflad]

Hi @svenwltr 👋 thanks for submitting this! We actually have an open pull request for this functionality that was just missing the testing that you have: #4307

Would you be able to instead branch off that existing work and apply your testing in a commit after those? We should be able to release this immediately afterwards, we just want to be sure the original author gets credit as well. Thanks so much!

[svenwltr]

Uhm, okay. Done.

% make testacc TESTARGS='-run=TestAccAWSWafRegionalWebAcl_createRateBased'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSWafRegionalWebAcl_createRateBased -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalWebAcl_createRateBased
--- PASS: TestAccAWSWafRegionalWebAcl_createRateBased (26.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.037s

[bflad]

After updating computeWafRegionalWebAclRuleIndex to accept the rule type as well, this looks great! 🚀

make testacc TEST=./aws TESTARGS='-run=TestAccAWSWafRegionalWebAcl_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSWafRegionalWebAcl_ -timeout 120m
=== RUN   TestAccAWSWafRegionalWebAcl_basic
--- PASS: TestAccAWSWafRegionalWebAcl_basic (19.00s)
=== RUN   TestAccAWSWafRegionalWebAcl_createRateBased
--- PASS: TestAccAWSWafRegionalWebAcl_createRateBased (19.31s)
=== RUN   TestAccAWSWafRegionalWebAcl_changeNameForceNew
--- PASS: TestAccAWSWafRegionalWebAcl_changeNameForceNew (32.45s)
=== RUN   TestAccAWSWafRegionalWebAcl_changeDefaultAction
--- PASS: TestAccAWSWafRegionalWebAcl_changeDefaultAction (33.24s)
=== RUN   TestAccAWSWafRegionalWebAcl_disappears
--- PASS: TestAccAWSWafRegionalWebAcl_disappears (17.45s)
=== RUN   TestAccAWSWafRegionalWebAcl_noRules
--- PASS: TestAccAWSWafRegionalWebAcl_noRules (13.67s)
=== RUN   TestAccAWSWafRegionalWebAcl_changeRules
--- PASS: TestAccAWSWafRegionalWebAcl_changeRules (30.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	165.650s

[omeid]

Thank you so much for working to land this. @svenwltr.

[bflad]

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!