Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ssm_document: Support tagging #5020

Merged
merged 1 commit into from
Jun 29, 2018
Merged

resource/aws_ssm_document: Support tagging #5020

merged 1 commit into from
Jun 29, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 28, 2018

Closes #5015

Changes proposed in this pull request:

  • Add tags argument to aws_ssm_document resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMDocument'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMDocument -timeout 120m
=== RUN   TestAccAWSSSMDocument_basic
--- PASS: TestAccAWSSSMDocument_basic (13.75s)
=== RUN   TestAccAWSSSMDocument_update
--- PASS: TestAccAWSSSMDocument_update (23.39s)
=== RUN   TestAccAWSSSMDocument_permission
--- PASS: TestAccAWSSSMDocument_permission (13.44s)
=== RUN   TestAccAWSSSMDocument_params
--- PASS: TestAccAWSSSMDocument_params (14.05s)
=== RUN   TestAccAWSSSMDocument_automation
--- PASS: TestAccAWSSSMDocument_automation (21.79s)
=== RUN   TestAccAWSSSMDocument_DocumentFormat_YAML
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (23.35s)
=== RUN   TestAccAWSSSMDocument_Tags
--- PASS: TestAccAWSSSMDocument_Tags (30.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	140.224s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. labels Jun 28, 2018
@bflad bflad requested a review from a team June 28, 2018 17:23
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jun 28, 2018
@bflad bflad mentioned this pull request Jun 28, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.26.0 milestone Jun 29, 2018
@bflad bflad merged commit 217c7ff into master Jun 29, 2018
@bflad bflad deleted the f-aws_ssm_document-tags branch June 29, 2018 17:41
bflad added a commit that referenced this pull request Jun 29, 2018
@bflad
Update CHANGELOG for #5020
3855870
@bflad
Copy link
Contributor Author

bflad commented Jul 4, 2018

This has been released in version 1.26.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.

Feature Request - support tags field in aws_ssm_document
2 participants
@bflad @tombuildsstuff