Add support for glue connection vpc availability zones (required currently)

[narfman0]

Fixes #4762

Changes proposed in this pull request:

• Add support for AvailabilityZone, currently required by the PhysicalConnectionRequirements structure per aws api PhysicalConnectionRequirements documentation

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSAvailabilityZones -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSAvailabilityZones_basic
--- PASS: TestAccAWSAvailabilityZones_basic (15.28s)
=== RUN   TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_stateFilter (14.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.022s

[bflad]

LGTM with one minor testing fix, in a commit after yours. Thanks @narfman0! 🚀

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueConnection'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueConnection -timeout 120m
=== RUN   TestAccAWSGlueConnection_Basic
--- PASS: TestAccAWSGlueConnection_Basic (13.37s)
=== RUN   TestAccAWSGlueConnection_Description
--- PASS: TestAccAWSGlueConnection_Description (21.69s)
=== RUN   TestAccAWSGlueConnection_MatchCriteria
--- PASS: TestAccAWSGlueConnection_MatchCriteria (27.52s)
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (651.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	714.249s

[bflad]

This addition was not working in the acceptance testing:

--- FAIL: TestAccAWSGlueConnection_PhysicalConnectionRequirements (0.91s)
	testing.go:518: Step 0 error: Error loading configuration: Error loading /var/folders/v0/_d108fkx1pbbg4_sh864_7740000gn/T/tf-test582550071/main.tf: Error reading config for aws_glue_connection[test]: parse error at 1:38: expected "}" but found "."

Changing it to availability_zone = "${aws_subnet.test.0.availability_zone}" worked as expected 👍

Also we normally recommend adding a check that a new attribute is at least set in the acceptance testing: resource.TestCheckResourceAttrSet(resourceName, "physical_connection_requirements.0.availability_zone"),

[narfman0]

OK excellent thanks for your comments and effort! I'll check this TestCheckResourceAttrSet further later ;)

[bflad]

This has been released in version 1.27.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!