Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_kms_grant: Properly return error when listing KMS grants #5063

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 3, 2018

Fixes #5062

Changes proposed in this pull request:

  • Properly return ListGrants errors from findKmsGrantById() instead of crashing
  • Additionally prevent potential nil dereferencing panics by using SDK methods in findKmsGrantById()

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAWSKmsGrant'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAWSKmsGrant -timeout 120m
=== RUN   TestAWSKmsGrant_Basic
--- PASS: TestAWSKmsGrant_Basic (53.14s)
=== RUN   TestAWSKmsGrant_withConstraints
--- PASS: TestAWSKmsGrant_withConstraints (82.90s)
=== RUN   TestAWSKmsGrant_withRetiringPrincipal
--- PASS: TestAWSKmsGrant_withRetiringPrincipal (52.32s)
=== RUN   TestAWSKmsGrant_bare
--- PASS: TestAWSKmsGrant_bare (52.20s)
=== RUN   TestAWSKmsGrant_ARN
--- PASS: TestAWSKmsGrant_ARN (51.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	292.322s

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/kms Issues and PRs that pertain to the kms service. labels Jul 3, 2018
@bflad bflad added this to the v1.26.0 milestone Jul 3, 2018
@bflad bflad requested a review from a team July 3, 2018 17:54
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jul 3, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@bflad bflad modified the milestones: v1.26.0, v1.27.0 Jul 5, 2018
@bflad bflad merged commit dcfa150 into master Jul 5, 2018
@bflad bflad deleted the b-aws_kms_grant-missing-err-check branch July 5, 2018 16:21
bflad added a commit that referenced this pull request Jul 5, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 11, 2018

This has been released in version 1.27.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_kms_grant EOF issue when permission is missing
2 participants