Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to region data source #5077

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

julienduchesne
Copy link
Contributor

Changes proposed in this pull request:

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccDataSourceAwsRegion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccDataSourceAwsRegion -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccDataSourceAwsRegion_basic
--- PASS: TestAccDataSourceAwsRegion_basic (9.52s)
=== RUN   TestAccDataSourceAwsRegion_endpoint
--- PASS: TestAccDataSourceAwsRegion_endpoint (12.29s)
=== RUN   TestAccDataSourceAwsRegion_endpointAndName
--- PASS: TestAccDataSourceAwsRegion_endpointAndName (18.11s)
=== RUN   TestAccDataSourceAwsRegion_name
--- PASS: TestAccDataSourceAwsRegion_name (12.92s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       52.854s

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jul 4, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jul 5, 2018
@bflad bflad added this to the v1.27.0 milestone Jul 5, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @julienduchesne! 🚀

4 tests passed (all tests)
=== RUN   TestAccDataSourceAwsRegion_basic
--- PASS: TestAccDataSourceAwsRegion_basic (9.65s)
=== RUN   TestAccDataSourceAwsRegion_endpoint
--- PASS: TestAccDataSourceAwsRegion_endpoint (12.69s)
=== RUN   TestAccDataSourceAwsRegion_name
--- PASS: TestAccDataSourceAwsRegion_name (13.05s)
=== RUN   TestAccDataSourceAwsRegion_endpointAndName
--- PASS: TestAccDataSourceAwsRegion_endpointAndName (18.98s)

@bflad bflad merged commit 955b907 into hashicorp:master Jul 6, 2018
bflad added a commit that referenced this pull request Jul 6, 2018
@julienduchesne julienduchesne deleted the add-description-region-data branch July 6, 2018 17:29
@bflad
Copy link
Contributor

bflad commented Jul 11, 2018

This has been released in version 1.27.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants