add cpu options support via cpu_core_count and cpu_threads_per_core #4490

[brokenbot]

Fixes #4490

Changes proposed in this pull request:

• adds optional attribute cpu_core_count to set CpuOptions.CoreCount
• adds optional attribute cpu_threads_per_core to set CpuOptions.ThreadsPerCore

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'

...

[jen20]

Hi @brokenbot! Thanks for opening a pull request. I've gone through and cleaned up a couple of typos in the docs and merged this, it should appear in the next release of the AWS provider.

[bflad]

This has been released in version 1.29.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[cskalyan]

I have been trying to use these arguments cpu_options and cpu_threads_per_core. When terraform apply fails for the first time some reason and when I execute terraform apply again, it is destryoing the existing instance and creating a new instance. Without cpu_options and cpu_threads_per_core, Instance does not get destroyed.

[bflad]

@cskalyan I'd suggest opening a new bug report issue with all the relevant details from the issue template so we can further troubleshoot, thanks. 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!