Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_efs_file_system: Add provisioned_throughput_in_mibps and throughput_mode arguments #5210

Merged
merged 1 commit into from
Jul 31, 2018
Merged

resource/aws_efs_file_system: Add provisioned_throughput_in_mibps and throughput_mode arguments #5210

merged 1 commit into from
Jul 31, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 17, 2018

Closes #5203

Changes proposed in this pull request:

  • Add provisioned_throughput_in_mibps and throughput_mode arguments to aws_efs_file_system resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEFSFileSystem'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEFSFileSystem -timeout 120m
=== RUN   TestAccAWSEFSFileSystem_importBasic
--- PASS: TestAccAWSEFSFileSystem_importBasic (22.10s)
=== RUN   TestAccAWSEFSFileSystem_basic
--- PASS: TestAccAWSEFSFileSystem_basic (47.58s)
=== RUN   TestAccAWSEFSFileSystem_pagedTags
--- PASS: TestAccAWSEFSFileSystem_pagedTags (20.64s)
=== RUN   TestAccAWSEFSFileSystem_kmsKey
--- PASS: TestAccAWSEFSFileSystem_kmsKey (48.20s)
=== RUN   TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (32.63s)
=== RUN   TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (33.07s)
=== RUN   TestAccAWSEFSFileSystem_ThroughputMode
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (32.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	237.164s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. labels Jul 17, 2018
@bflad bflad requested a review from a team July 17, 2018 00:50
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 17, 2018
@bflad bflad mentioned this pull request Jul 17, 2018
Closed
paultyng
paultyng reviewed Jul 31, 2018
View reviewed changes
aws/resource_aws_efs_file_system.go
@@ -73,7 +73,22 @@ func resourceAwsEfsFileSystem() *schema.Resource {
Computed: true,
},

"provisioned_throughput_in_mibps": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this name for some reason.

@bflad bflad added this to the v1.30.0 milestone Jul 31, 2018
@bflad bflad merged commit c7442e8 into master Jul 31, 2018
@bflad bflad deleted the f-aws_efs_file_system-throughput_mode branch July 31, 2018 15:14
bflad added a commit that referenced this pull request Jul 31, 2018
@bflad
Update CHANGELOG for #5210
7d6edef
@bflad
Copy link
Contributor Author

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

Update Terraform to Support EFS's New Provisioned Throughput Support
2 participants
@bflad @paultyng