Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_neptune_cluster: Support import and refactoring #5227

Merged
merged 1 commit into from
Jul 26, 2018
Merged

resource/aws_neptune_cluster: Support import and refactoring #5227

merged 1 commit into from
Jul 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 18, 2018

Changes proposed in this pull request:

  • Support resource import
  • Refactor create/restore input logic to simplify
  • Alphabetize d.Set() calls
  • Ensure documentation page has -x to match sidebar

Output from acceptance testing:

9 tests passed (all tests)
=== RUN   TestAccAWSNeptuneCluster_updateTags
--- PASS: TestAccAWSNeptuneCluster_updateTags (113.70s)
=== RUN   TestAccAWSNeptuneCluster_kmsKey
--- PASS: TestAccAWSNeptuneCluster_kmsKey (117.63s)
=== RUN   TestAccAWSNeptuneCluster_basic
--- PASS: TestAccAWSNeptuneCluster_basic (118.67s)
=== RUN   TestAccAWSNeptuneCluster_namePrefix
--- PASS: TestAccAWSNeptuneCluster_namePrefix (119.00s)
=== RUN   TestAccAWSNeptuneCluster_encrypted
--- PASS: TestAccAWSNeptuneCluster_encrypted (119.10s)
=== RUN   TestAccAWSNeptuneCluster_iamAuth
--- PASS: TestAccAWSNeptuneCluster_iamAuth (138.85s)
=== RUN   TestAccAWSNeptuneCluster_backupsUpdate
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (163.50s)
=== RUN   TestAccAWSNeptuneCluster_takeFinalSnapshot
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (169.30s)
=== RUN   TestAccAWSNeptuneCluster_updateIamRoles
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (184.62s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/neptune Issues and PRs that pertain to the neptune service. labels Jul 18, 2018
@bflad bflad requested a review from a team July 18, 2018 01:03
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 18, 2018
catsby
catsby approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bflad bflad added this to the v1.30.0 milestone Jul 26, 2018
@bflad bflad merged commit 558843a into master Jul 26, 2018
@bflad bflad deleted the f-aws_neptune_cluster-import branch July 26, 2018 20:21
bflad added a commit that referenced this pull request Jul 26, 2018
@bflad
Update CHANGELOG for #5227
04d4207
@bflad
Copy link
Contributor Author

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/neptune Issues and PRs that pertain to the neptune service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @catsby