resource/aws_waf_web_acl: Properly update rules #5380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also includes other function refactoring to make the WAF and WAF Regional Web ACL resources behave similarly. make testacc TEST=./aws TESTARGS='-run=TestAccAWSWaf\(Regional\)\?WebAcl_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSWaf\(Regional\)\?WebAcl_ -timeout 120m === RUN TestAccAWSWafWebAcl_basic --- PASS: TestAccAWSWafWebAcl_basic (14.46s) === RUN TestAccAWSWafWebAcl_changeNameForceNew --- PASS: TestAccAWSWafWebAcl_changeNameForceNew (22.92s) === RUN TestAccAWSWafWebAcl_DefaultAction --- PASS: TestAccAWSWafWebAcl_DefaultAction (20.89s) === RUN TestAccAWSWafWebAcl_Rules --- PASS: TestAccAWSWafWebAcl_Rules (41.19s) === RUN TestAccAWSWafWebAcl_disappears --- PASS: TestAccAWSWafWebAcl_disappears (10.02s) === RUN TestAccAWSWafRegionalWebAcl_basic --- PASS: TestAccAWSWafRegionalWebAcl_basic (21.19s) === RUN TestAccAWSWafRegionalWebAcl_createRateBased --- PASS: TestAccAWSWafRegionalWebAcl_createRateBased (22.72s) === RUN TestAccAWSWafRegionalWebAcl_createGroup --- PASS: TestAccAWSWafRegionalWebAcl_createGroup (23.46s) === RUN TestAccAWSWafRegionalWebAcl_changeNameForceNew --- PASS: TestAccAWSWafRegionalWebAcl_changeNameForceNew (42.56s) === RUN TestAccAWSWafRegionalWebAcl_changeDefaultAction --- PASS: TestAccAWSWafRegionalWebAcl_changeDefaultAction (41.41s) === RUN TestAccAWSWafRegionalWebAcl_disappears --- PASS: TestAccAWSWafRegionalWebAcl_disappears (21.20s) === RUN TestAccAWSWafRegionalWebAcl_noRules --- PASS: TestAccAWSWafRegionalWebAcl_noRules (17.18s) === RUN TestAccAWSWafRegionalWebAcl_changeRules --- PASS: TestAccAWSWafRegionalWebAcl_changeRules (33.23s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 333.027s
bflad
added
bug
|
This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
@bflad i can confirm that is is fixing issue we had with waf. After running plan tf found a lot of "orphans" and been able to finally remove them 👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #534
Fixes #4786
Changes proposed in this pull request:
diffWafWebAclRules()duringaws_waf_web_aclresource updatesaws_waf_web_acltesting conventions and only create rules in testing where necessaryOutput from acceptance testing: