Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_db_instance: Allow alert, listener, and trace for enabled_cloudwatch_logs_exports #5494

Merged
merged 1 commit into from
Aug 13, 2018
Merged

resource/aws_db_instance: Allow alert, listener, and trace for enabled_cloudwatch_logs_exports #5494

merged 1 commit into from
Aug 13, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 9, 2018

Fixes #5235
Fixes #5253

Changes proposed in this pull request:

  • On the tin

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle -timeout 120m
=== RUN   TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (578.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	579.497s

@bflad
resource/aws_db_instance: Allow alert, listener, and trace for enable…
c5bf299 
…d_cloudwatch_logs_exports

make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle -timeout 120m
=== RUN   TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (578.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	579.497s
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. labels Aug 9, 2018
@bflad bflad requested a review from a team August 9, 2018 21:24
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Aug 9, 2018
This was referenced Aug 10, 2018
Closed
Closed
tombuildsstuff
tombuildsstuff approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.32.0 milestone Aug 13, 2018
@bflad bflad merged commit ee9262b into master Aug 13, 2018
@bflad bflad deleted the f-aws_db_instance-oracle-log-exports branch August 13, 2018 13:44
bflad added a commit that referenced this pull request Aug 13, 2018
@bflad
Update CHANGELOG for #5494
8c63edf
@bflad
Copy link
Contributor Author

bflad commented Aug 16, 2018

This has been released in version 1.32.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.32.0
2 participants
@bflad @tombuildsstuff