Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_elasticache_cluster: Allow availability_zone to be specified with replication_group_id #5585

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 17, 2018

Fixes #5579

Changes proposed in this pull request:

  • Remove availability_zone from the replication_group_id ConflictsWith

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic -timeout 120m
=== RUN   TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic (1084.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1085.065s

…fied with replication_group_id

* Remove availability_zone from the replication_group_id ConflictsWith

make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic -timeout 120m
=== RUN   TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic (1084.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1085.065s
@bflad bflad added bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service. labels Aug 17, 2018
@bflad bflad requested a review from a team August 17, 2018 04:26
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Aug 17, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bflad bflad added this to the v1.33.0 milestone Aug 20, 2018
@bflad bflad merged commit f6ef998 into master Aug 20, 2018
@bflad bflad deleted the b-aws_elasticache_cluster-replication-group-id-az branch August 20, 2018 20:07
bflad added a commit that referenced this pull request Aug 20, 2018
@bflad
Copy link
Contributor Author

bflad commented Aug 22, 2018

This has been released in version 1.33.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_elasticache_cluster doesn't allow availability_zone when replication_group_id is set
2 participants