resource/aws_waf(regional)_ipset: Properly handle updates and deletions over 1000 IP set descriptors #5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
bug
…ns over 1000 IP set descriptors * Perform batching of 1000 Updates with UpdateIPSet Previously: --- FAIL: TestAccAWSWafIPSet_IpSetDescriptors_1000UpdateLimit (8.02s) testing.go:527: Step 0 error: Error applying: 1 error occurred: * aws_waf_ipset.ipset: 1 error occurred: * aws_waf_ipset.ipset: Error Updating WAF IPSet: Error Updating WAF IPSet: WAFLimitsExceededException: Operation would result in exceeding resource limits. --- FAIL: TestAccAWSWafRegionalIPSet_IpSetDescriptors_1000UpdateLimit (10.55s) testing.go:527: Step 0 error: Error applying: 1 error occurred: * aws_wafregional_ipset.ipset: 1 error occurred: * aws_wafregional_ipset.ipset: Error Updating WAF IPSet: Error Updating WAF IPSet: WAFLimitsExceededException: Operation would result in exceeding resource limits. Now passes: make testacc TEST=./aws TESTARGS='-run=TestAccAWSWaf\(Regional\)\?IPSet_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSWaf\(Regional\)\?IPSet_ -timeout 120m === RUN TestAccAWSWafIPSet_basic --- PASS: TestAccAWSWafIPSet_basic (11.79s) === RUN TestAccAWSWafIPSet_disappears --- PASS: TestAccAWSWafIPSet_disappears (7.02s) === RUN TestAccAWSWafIPSet_changeNameForceNew --- PASS: TestAccAWSWafIPSet_changeNameForceNew (18.54s) === RUN TestAccAWSWafIPSet_changeDescriptors --- PASS: TestAccAWSWafIPSet_changeDescriptors (15.31s) === RUN TestAccAWSWafIPSet_noDescriptors --- PASS: TestAccAWSWafIPSet_noDescriptors (8.89s) === RUN TestAccAWSWafIPSet_IpSetDescriptors_1000UpdateLimit --- PASS: TestAccAWSWafIPSet_IpSetDescriptors_1000UpdateLimit (26.55s) === RUN TestAccAWSWafRegionalIPSet_basic --- PASS: TestAccAWSWafRegionalIPSet_basic (13.73s) === RUN TestAccAWSWafRegionalIPSet_disappears --- PASS: TestAccAWSWafRegionalIPSet_disappears (13.02s) === RUN TestAccAWSWafRegionalIPSet_changeNameForceNew --- PASS: TestAccAWSWafRegionalIPSet_changeNameForceNew (26.81s) === RUN TestAccAWSWafRegionalIPSet_changeDescriptors --- PASS: TestAccAWSWafRegionalIPSet_changeDescriptors (22.95s) === RUN TestAccAWSWafRegionalIPSet_IpSetDescriptors_1000UpdateLimit --- PASS: TestAccAWSWafRegionalIPSet_IpSetDescriptors_1000UpdateLimit (33.62s) === RUN TestAccAWSWafRegionalIPSet_noDescriptors --- PASS: TestAccAWSWafRegionalIPSet_noDescriptors (10.92s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 209.782s
bflad
force-pushed
the
b-aws_waf_ipset-1000-batches
branch
from
fe8f004 to
0a3549b
Compare
|
This has been released in version 1.33.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #833
Previously:
Changes proposed in this pull request:
Output from acceptance testing: