Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_service_discovery_public_dns_namespace name length limit #5610

Merged
merged 3 commits into from
Aug 21, 2018

Conversation

Frogvall
Copy link

Fixes #5339

Changes proposed in this pull request:

  • Trim name if needed to comply to the 64 character limit to RequestId

Output from acceptance testing:

  • Did make acceptance test. Spent a few hours trying to make it run in our company environment, but just wouldn't work.

Basically just does what was done in #4702, and as was suggested by @bflad

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Aug 20, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. labels Aug 20, 2018
@bflad bflad added this to the v1.33.0 milestone Aug 21, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Frogvall! I fixed up the acceptance testing so we can get this merged and released this week. 🚀

make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceDiscoveryPublicDnsNamespace_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSServiceDiscoveryPublicDnsNamespace_ -timeout 120m
=== RUN   TestAccAWSServiceDiscoveryPublicDnsNamespace_basic
--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_basic (13.60s)
=== RUN   TestAccAWSServiceDiscoveryPublicDnsNamespace_longname
--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_longname (12.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.782s

@bflad bflad merged commit 5fc7bad into hashicorp:master Aug 21, 2018
bflad added a commit that referenced this pull request Aug 21, 2018
@Frogvall
Copy link
Author

Great, thank you!

@bflad
Copy link
Contributor

bflad commented Aug 22, 2018

This has been released in version 1.33.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_service_discovery_public_dns_namespace name length limit
2 participants