Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_db_instance: Prevent is already being deleted error on deletion #5624

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 21, 2018

Fixes #5622

Previously:

--- FAIL: TestAccAWSDBInstance_IsAlreadyBeingDeleted (238.05s)
	testing.go:527: Step 1 error: Error applying: 1 error occurred:
			* aws_db_instance.test (destroy): 1 error occurred:
			* aws_db_instance.test: InvalidDBInstanceState: Instance tf-acc-test-1508345143008358561 is already being deleted.

Changes proposed in this pull request:

  • Ignore InvalidDBInstanceState: Instance XXX is already being deleted error from DeleteDBInstance and continue waiting for deletion

Output from acceptance testing:

--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (453.66s)

…eletion

* Ignore InvalidDBInstanceState: Instance XXX is already being deleted error from DeleteDBInstance and continue waiting for deletion

Previously:

```
--- FAIL: TestAccAWSDBInstance_IsAlreadyBeingDeleted (238.05s)
	testing.go:527: Step 1 error: Error applying: 1 error occurred:
			* aws_db_instance.test (destroy): 1 error occurred:
			* aws_db_instance.test: InvalidDBInstanceState: Instance tf-acc-test-1508345143008358561 is already being deleted.
```

After code change:

```
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (453.66s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. labels Aug 21, 2018
@bflad bflad requested a review from a team August 21, 2018 13:30
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Aug 21, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bflad bflad added this to the v1.33.0 milestone Aug 22, 2018
@bflad bflad merged commit 1e27166 into master Aug 22, 2018
@bflad bflad deleted the b-aws_db_instance-already-being-deleted branch August 22, 2018 13:38
bflad added a commit that referenced this pull request Aug 22, 2018
@bflad
Copy link
Contributor Author

bflad commented Aug 22, 2018

This has been released in version 1.33.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDS destruction fails with: Instance db-name is already being deleted
2 participants