Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_autoscaling_group: Retry creation for eventual consistency with launch template IAM instance profile #5633

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 21, 2018

Fixes #5217

Previously:

--- FAIL: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (14.43s)
	testing.go:527: Step 0 error: Error applying: 1 error occurred:
			* aws_autoscaling_group.test: 1 error occurred:
			* aws_autoscaling_group.test: Error creating AutoScaling Group: ValidationError: You must use a valid fully-formed launch template. Value (tf-acc-test-6643732652421074386) for parameter iamInstanceProfile.name is invalid. Invalid IAM Instance Profile name

Changes proposed in this pull request:

  • On the tin. 😄

Output from acceptance testing:

--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (59.25s)

…cy with launch template IAM instance profile

Previously:

```
--- FAIL: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (14.43s)
	testing.go:527: Step 0 error: Error applying: 1 error occurred:
			* aws_autoscaling_group.test: 1 error occurred:
			* aws_autoscaling_group.test: Error creating AutoScaling Group: ValidationError: You must use a valid fully-formed launch template. Value (tf-acc-test-6643732652421074386) for parameter iamInstanceProfile.name is invalid. Invalid IAM Instance Profile name
```

After code changes:

```
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (59.25s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Aug 21, 2018
@bflad bflad requested a review from a team August 21, 2018 18:12
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Aug 21, 2018
@bflad bflad added this to the v1.34.0 milestone Aug 30, 2018
@bflad bflad merged commit ebcb99d into master Aug 30, 2018
@bflad bflad deleted the b-aws_autoscaling_group-lt-instance-profile branch August 30, 2018 12:41
bflad added a commit that referenced this pull request Aug 30, 2018
@bflad
Copy link
Contributor Author

bflad commented Aug 30, 2018

This has been released in version 1.34.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

launch_template error when using new iam_instance_profile
2 participants