Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipv6_cidr_blocks attribute to aws_ip_ranges data source #5675

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Add ipv6_cidr_blocks attribute to aws_ip_ranges data source #5675

merged 1 commit into from
Aug 30, 2018

Conversation

haines
Copy link
Contributor

@haines haines commented Aug 24, 2018

Changes proposed in this pull request:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIPRanges'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSIPRanges -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSIPRanges
--- PASS: TestAccAWSIPRanges (14.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.763s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. labels Aug 27, 2018
@bflad bflad added this to the v1.34.0 milestone Aug 30, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @haines! 🚀

--- PASS: TestAccAWSIPRanges (3.81s)

@bflad bflad merged commit 6a403b8 into hashicorp:master Aug 30, 2018
bflad added a commit that referenced this pull request Aug 30, 2018
@haines haines deleted the ipv6-ranges branch August 30, 2018 21:06
@bflad
Copy link
Contributor

bflad commented Aug 30, 2018

This has been released in version 1.34.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants