Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ForceNew for aws_redshift_cluster on availability_zone change #5758

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

Victorion
Copy link
Contributor

Fixes #5757

Changes proposed in this pull request:

  • Added "ForceNew: true" for aws_redshift_cluster on availability_zone change
  • Added acceptance test: TestAccAWSRedshiftCluster_changeAvailabilityZone
  • Added config: testAccAWSRedshiftClusterConfig_updatedAvailabilityZone
  • Added simple check: testAccCheckAWSRedshiftClusterAvailabilityZone

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRedshiftCluster_changeAvailabilityZone'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRedshiftCluster_changeAvailabilityZone -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_changeAvailabilityZone
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (2331.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2331.736s
...

@bflad bflad added bug Addresses a defect in current functionality. service/redshift Issues and PRs that pertain to the redshift service. labels Sep 4, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Victorion! 🚀

(test failure unrelated)

--- PASS: TestAccAWSRedshiftCluster_basic (852.63s)
--- PASS: TestAccAWSRedshiftCluster_tags (882.12s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabledDeprecated (901.70s)
--- FAIL: TestAccAWSRedshiftCluster_loggingEnabled (906.62s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (988.78s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (1015.03s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1019.34s)
--- PASS: TestAccAWSRedshiftCluster_importBasic (1068.13s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (1081.38s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (1172.05s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (1414.80s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1801.14s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (1840.33s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (2877.67s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (3010.42s)

@bflad bflad added this to the v1.35.0 milestone Sep 4, 2018
@bflad bflad merged commit 207e050 into hashicorp:master Sep 4, 2018
bflad added a commit that referenced this pull request Sep 4, 2018
@bflad
Copy link
Contributor

bflad commented Sep 6, 2018

This has been released in version 1.35.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
@Victorion Victorion deleted the master branch October 13, 2021 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/redshift Issues and PRs that pertain to the redshift service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_redshift_cluster: availability_zone should apply ForceNew on the resource
2 participants