Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_s3_bucket_inventory: Allow SSE-S3 encryption #5870

Merged
merged 1 commit into from
Sep 14, 2018
Merged

resource/aws_s3_bucket_inventory: Allow SSE-S3 encryption #5870

merged 1 commit into from
Sep 14, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 13, 2018

The upstream AWS Go SDK issue was fixed. 🎉

Closes #5046

Changes proposed in this pull request:

  • Remove apply-time restrictions for SSE-S3 encryption support for aws_s3_bucket_inventory resousrce

Output from acceptance testing:

--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (6.59s)
--- PASS: TestAccAWSS3BucketInventory_basic (7.09s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (27.21s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. labels Sep 13, 2018
@bflad bflad requested a review from a team September 13, 2018 17:24
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Sep 13, 2018
@bflad bflad requested review from a team and removed request for a team September 13, 2018 18:38
tombuildsstuff
tombuildsstuff approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.37.0 milestone Sep 14, 2018
@bflad bflad merged commit 6190f3c into master Sep 14, 2018
@bflad bflad deleted the f-aws_s3_bucket_inventory-sse-s3 branch September 14, 2018 12:43
bflad added a commit that referenced this pull request Sep 14, 2018
@bflad
Update CHANGELOG for #5870
26ebba6
@bflad
Copy link
Contributor Author

bflad commented Sep 19, 2018

This has been released in version 1.37.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.37.0
Development

Successfully merging this pull request may close these issues.

Add SSE-S3 encryption support for S3 inventory
2 participants
@bflad @tombuildsstuff