Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prefix_list_ids on ingress rules in an aws_security_group #5916

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

w4
Copy link
Contributor

@w4 w4 commented Sep 18, 2018

prefix_list_ids is already allowed on ingress aws_security_group_rules but not available when using inline ingress rules.

➜ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSecurityGroup_ingressWithPrefixList'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSSecurityGroup_ingressWithPrefixList -timeout 120m
=== RUN   TestAccAWSSecurityGroup_ingressWithPrefixList
--- PASS: TestAccAWSSecurityGroup_ingressWithPrefixList (72.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	73.326s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 18, 2018
prefix_list_ids is already allowed on ingress aws_security_group_rules
but not available when using inline ingress rules.
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 18, 2018
@w4 w4 changed the title Allow prefix_list_ids on ingress rules in a aws_security_group Allow prefix_list_ids on ingress rules in an aws_security_group Sep 18, 2018
@bflad bflad added the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 18, 2018
@bflad bflad added this to the v1.37.0 milestone Sep 18, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @w4! 🚀

(test failures unrelated)

Tests failed: 5 (1 new), passed: 34
--- PASS: TestAccAWSSecurityGroup_namePrefix (11.63s)
--- PASS: TestAccAWSSecurityGroup_self (36.56s)
--- PASS: TestAccAWSSecurityGroup_MultiIngress (36.17s)
--- PASS: TestAccAWSSecurityGroup_importIPRangesWithSameRules (40.11s)
--- PASS: TestAccAWSSecurityGroup_vpc (43.57s)
--- PASS: TestAccAWSSecurityGroup_basic (45.09s)
--- PASS: TestAccAWSSecurityGroup_importBasic (45.24s)
--- PASS: TestAccAWSSecurityGroup_invalidCIDRBlock (0.85s)
--- PASS: TestAccAWSSecurityGroup_DefaultEgress_Classic (9.62s)
--- PASS: TestAccAWSSecurityGroup_drift (8.54s)
--- PASS: TestAccAWSSecurityGroup_importSelf (48.77s)
--- PASS: TestAccAWSSecurityGroup_vpcProtoNumIngress (49.11s)
--- PASS: TestAccAWSSecurityGroup_importPrefixList (51.55s)
--- PASS: TestAccAWSSecurityGroup_generatedName (40.13s)
--- PASS: TestAccAWSSecurityGroup_ruleGathering (52.00s)
--- PASS: TestAccAWSSecurityGroup_importSourceSecurityGroup (52.25s)
--- PASS: TestAccAWSSecurityGroup_importIpv6 (57.40s)
--- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGs_classic (14.95s)
--- PASS: TestAccAWSSecurityGroup_DefaultEgress_VPC (28.82s)
--- PASS: TestAccAWSSecurityGroup_importIPRangeAndSecurityGroupWithSameRules (71.38s)
--- PASS: TestAccAWSSecurityGroup_drift_complex (31.08s)
--- PASS: TestAccAWSSecurityGroup_ipv4andipv6Egress (24.63s)
--- FAIL: TestAccAWSSecurityGroup_CIDRandGroups (34.89s)
--- PASS: TestAccAWSSecurityGroup_ipv6 (82.48s)
--- PASS: TestAccAWSSecurityGroup_failWithDiffMismatch (33.25s)
--- PASS: TestAccAWSSecurityGroup_Change (86.48s)
--- FAIL: TestAccAWSSecurityGroup_ruleLimitExceededAllNew (30.92s)
--- FAIL: TestAccAWSSecurityGroup_ruleLimitExceededPrepend (40.13s)
--- FAIL: TestAccAWSSecurityGroup_ruleLimitExceededAppend (45.81s)
--- PASS: TestAccAWSSecurityGroup_egressWithPrefixList (49.31s)
--- PASS: TestAccAWSSecurityGroup_tags (53.38s)
--- FAIL: TestAccAWSSecurityGroup_ruleLimitCidrBlockExceededAppend (48.71s)
--- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGs (55.03s)
--- PASS: TestAccAWSSecurityGroup_RuleDescription (102.05s)
--- PASS: TestAccAWSSecurityGroup_rulesDropOnError (44.19s)
--- PASS: TestAccAWSSecurityGroup_vpcNegOneIngress (110.91s)
--- PASS: TestAccAWSSecurityGroup_ingressWithPrefixList (82.76s)
--- PASS: TestAccAWSSecurityGroup_forceRevokeRules_false (647.22s)
--- PASS: TestAccAWSSecurityGroup_forceRevokeRules_true (654.55s)

@bflad bflad merged commit ab5af77 into hashicorp:master Sep 18, 2018
bflad added a commit that referenced this pull request Sep 18, 2018
@bflad
Copy link
Contributor

bflad commented Sep 19, 2018

This has been released in version 1.37.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants