Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Ensure validateTypeStringNullableBoolean accepts stringified "true" and "false" #5995

Merged
merged 1 commit into from
Sep 26, 2018
Merged

provider: Ensure validateTypeStringNullableBoolean accepts stringified "true" and "false" #5995

merged 1 commit into from
Sep 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 26, 2018 •
edited
Loading

schema.TypeBool will accept them, so we should continue to support that behavior with converting a "nullable" boolean attribute to schema.TypeString

Fixes #5994

Changes proposed in this pull request:

  • Allow "true" and "false" in validateTypeStringNullableBoolean

Output from acceptance testing:

--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (47.06s)

@bflad
provider: Ensure validateTypeStringNullableBoolean accepts stringifie…
8538d0a 
…d "true" and "false"

```
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (47.06s)
```
@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 26, 2018
@bflad bflad requested a review from a team September 26, 2018 17:07
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 26, 2018
@bflad bflad added this to the v1.38.0 milestone Sep 26, 2018
@bflad bflad merged commit ed6c7a0 into master Sep 26, 2018
@bflad bflad deleted the b-validateTypeStringNullableBoolean-strings branch September 26, 2018 19:41
bflad added a commit that referenced this pull request Sep 26, 2018
@bflad
Update CHANGELOG for #5995
80811b7
@bflad
Copy link
Contributor Author

bflad commented Sep 26, 2018

This has been released in version 1.38.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.38.0
Development

Successfully merging this pull request may close these issues.

ebs_optimized in resource_aws_launch_template doesn't accept string true/false
2 participants
@bflad @paddycarver