Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/codedeploy: Support resource import #6025

Merged
merged 3 commits into from
Oct 3, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 29, 2018

Closes #314
Closes #1473

Changes proposed in this pull request:

  • resource/aws_codedeploy_app: Support resource import
  • tests/resource/aws_codedeploy_app: Enhance acceptance testing
  • resource/aws_codedeploy_deployment_config: Support resource import
  • resource/aws_codedeploy_deployment_group: Support resource import
  • resource/aws_codedeploy_deployment_group: Properly read autoscaling_groups into Terraform state

Output from acceptance testing:

--- PASS: TestAccAWSCodeDeployApp_basic (13.20s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform (18.91s)
--- PASS: TestAccAWSCodeDeployApp_name (16.95s)

--- PASS: TestAccAWSCodeDeployDeploymentConfig_basic (12.22s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_fleetPercent (19.44s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_hostCount (17.21s)

--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (33.39s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (38.15s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (30.64s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (34.09s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (32.85s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (31.12s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (34.25s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (34.28s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (42.35s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (49.20s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (27.32s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (179.42s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (48.55s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (35.89s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (42.16s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (24.59s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (31.31s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (34.56s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (19.01s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_create (50.42s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (27.53s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (28.65s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (32.94s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (34.29s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (40.39s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (41.76s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (23.76s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (32.13s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (34.72s)

```
--- PASS: TestAccAWSCodeDeployDeploymentConfig_basic (12.22s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_fleetPercent (19.44s)
--- PASS: TestAccAWSCodeDeployDeploymentConfig_hostCount (17.21s)
```
```
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (33.39s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (38.15s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (30.64s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (34.09s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (32.85s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (31.12s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (34.25s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (34.28s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (42.35s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (49.20s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (27.32s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (179.42s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (48.55s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (35.89s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (42.16s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (24.59s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (31.31s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (34.56s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (19.01s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_create (50.42s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (27.53s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (28.65s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (32.94s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (34.29s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (40.39s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (41.76s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (23.76s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (32.13s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (34.72s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/codedeploy labels Sep 29, 2018
@bflad bflad requested a review from a team September 29, 2018 01:12
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 29, 2018
@bflad bflad added this to the v1.39.0 milestone Oct 3, 2018
@bflad bflad merged commit 2ca139f into master Oct 3, 2018
@bflad bflad deleted the f-aws_codedeploy_app-import branch October 3, 2018 16:49
bflad added a commit that referenced this pull request Oct 3, 2018
@ghost
Copy link

ghost commented Oct 3, 2018

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "aws" {
	version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support codedeploy import app provider/aws: Support Import aws_codedeploy_app
2 participants