Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_pinpoint_gcm_channel #6089

Merged
merged 2 commits into from
Oct 8, 2018

Conversation

marcoreni
Copy link
Contributor

Work continues on #4990

Changes proposed in this pull request:

  • New resource aws_pinpoint_gcm_channel with related docs and acceptance tests

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSPinpointGCMChannel'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSPinpointGCMChannel -timeout 120m
=== RUN   TestAccAWSPinpointGCMChannel_basic
--- PASS: TestAccAWSPinpointGCMChannel_basic (18.88s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       20.085s

NOTES:

  1. I recycled env GCM_API_KEY since it was already defined in other tests and name suggested it to be generic. Test is skipped if env is missing
  2. api_key is ignored during import since the SDK never returns it.

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 8, 2018
@marcoreni marcoreni mentioned this pull request Oct 8, 2018
@bflad bflad added the service/pinpoint Issues and PRs that pertain to the pinpoint service. label Oct 8, 2018
@bflad bflad added this to the v1.40.0 milestone Oct 8, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the other similar resources and submitted acceptance testing output (I don't think we should hold this up on getting our own GCM API key). Thanks, @marcoreni! 🚀

@bflad bflad merged commit 5524397 into hashicorp:master Oct 8, 2018
bflad added a commit that referenced this pull request Oct 8, 2018
@marcoreni marcoreni deleted the feature/4990_pinpoint_gcm_channel branch October 8, 2018 15:22
@bflad
Copy link
Contributor

bflad commented Oct 10, 2018

This has been released in version 1.40.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/pinpoint Issues and PRs that pertain to the pinpoint service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants