-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the custom domain name feature in aws_cognito_user_pool_domain resource #6185
Add the custom domain name feature in aws_cognito_user_pool_domain resource #6185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adelamarre 👋 Thanks for submitting this! Off to a great start -- I think just these two little things then it should be good to go. Please let us know if you have any questions or do not have time to implement the feedback. 👍
Co-Authored-By: adelamarre <ajdelamarre@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @adelamarre! I was able to verify this using the environment variables with a public ACM certificate and domain. 🚀
--- PASS: TestAccAWSCognitoUserPoolDomain_basic (9.03s)
--- PASS: TestAccAWSCognitoUserPoolDomain_custom (1563.45s)
This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #5026
Changes proposed in this pull request:
certificate_arn
parameter to let use a custom domainOutput from acceptance testing:
You need to set environment variable for this test :
This environment variable must be set to the fqdn of an ISSUED ACM certificate in us-east-1 to enable this test. The fqdn must have a A record in the zone.
This environment variable must be set to the ARN of an ISSUED ACM certificate in us-east-1 to enable this test.