-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_egress_only_internet_gateway: Adjust eventualy consistent logic #6190
aws_egress_only_internet_gateway: Adjust eventualy consistent logic #6190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up, @gseyetik! Two little things then I think this should be good to go.
Thank you for the feedback @bflad. Changes made. Test below.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gseyetik! 🚀
--- PASS: TestAccAWSEgressOnlyInternetGateway_basic (6.10s)
This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes eventually consistent creates not being captured by the current logic.
Changes proposed in this pull request:
InvalidEgressInternetGatewayID.NotFound
is not a real error. Instead the behaviour is an empty array. https://docs.aws.amazon.com/AWSEC2/latest/APIReference/errors-overview.html#CommonErrorsOther:
I kept the weird logic of checking the array for the id being found but I'm not sure that is really needed either.
Output from acceptance testing:
This is the first time I've tried to run the tests. If this wasn't done correctly let me know.