Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_pinpoint_apns_channel #6194

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

marcoreni
Copy link
Contributor

Work continues on #4990

Changes proposed in this pull request:

  • New resource aws_pinpoint_apns_channel with related docs and acceptance tests

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSPinpointAPNSChannel'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSPinpointAPNSChannel -timeout 120m
=== RUN   TestAccAWSPinpointAPNSChannel_basicCertificate
--- PASS: TestAccAWSPinpointAPNSChannel_basicCertificate (28.69s)
=== RUN   TestAccAWSPinpointAPNSChannel_basicToken
--- PASS: TestAccAWSPinpointAPNSChannel_basicToken (57.13s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       85.876s

NOTES:

  • As an Apple n00b I had some troubles finding the appropriate values required for the various attributes. I tried to explain as simple as possible (using references from AWS guides) what is needed, hope this is enough.
  • The tests require two set of credentials, one for TLS certificate credentials and the other for key credentials. The two tests are independent from each other, and inside the test file I referenced Apple docs about retrieving the credentials.
  • I tried to use the same key method used for sns_platform_application tests; I had some issues using the file path instead of the file contents as it's done here: https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_sns_platform_application_test.go#L56 ) because of: testing.go:538: Step 0 error: Error loading configuration: Error loading /tmp/tf-test026656738/main.tf: Error reading config for aws_pinpoint_apns_channel[test_apns_channel]: parse error at 1:19: expected expression but found invalid sequence "\\". I assume is caused by an HCL issue and I therefore decided to use only the first method (loading the file content inside the ENV).

The remaining resources (apns_sandbox_channel and apns_voip_*) are almost identical to this. Let me know if this is fine so that I can go on with the rest :)

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 18, 2018
@marcoreni marcoreni changed the title Feature/4990 pinpoint apns channel New resource: aws_pinpoint_apns_channel Oct 18, 2018
@bflad bflad added the service/pinpoint Issues and PRs that pertain to the pinpoint service. label Oct 18, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, based on the other Pinpoint resource implementations. Thanks, @marcoreni! 🚀

@bflad bflad added this to the v1.41.0 milestone Oct 18, 2018
@bflad bflad merged commit 7a562d4 into hashicorp:master Oct 18, 2018
bflad added a commit that referenced this pull request Oct 18, 2018
@bflad
Copy link
Contributor

bflad commented Oct 18, 2018

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@marcoreni marcoreni deleted the feature/4990_pinpoint_apns_channel branch October 22, 2018 10:28
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/pinpoint Issues and PRs that pertain to the pinpoint service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants