New resource: aws_pinpoint_apns_channel #6194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work continues on #4990
Changes proposed in this pull request:
aws_pinpoint_apns_channel
with related docs and acceptance testsOutput from acceptance testing:
NOTES:
sns_platform_application
tests; I had some issues using the file path instead of the file contents as it's done here: https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_sns_platform_application_test.go#L56 ) because of:testing.go:538: Step 0 error: Error loading configuration: Error loading /tmp/tf-test026656738/main.tf: Error reading config for aws_pinpoint_apns_channel[test_apns_channel]: parse error at 1:19: expected expression but found invalid sequence "\\"
. I assume is caused by an HCL issue and I therefore decided to use only the first method (loading the file content inside the ENV).The remaining resources (
apns_sandbox_channel
andapns_voip_*
) are almost identical to this. Let me know if this is fine so that I can go on with the rest :)