Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6144 Resource 'aws_iam_role_policy.example_policy' does not have attribute 'name' #6304

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Issue #6144 Resource 'aws_iam_role_policy.example_policy' does not have attribute 'name' #6304

merged 1 commit into from
Oct 30, 2018

Conversation

saravanan30erd
Copy link
Contributor

Fixes #6144

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSIAMRolePolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSIAMRolePolicy_ -timeout 120m
=== RUN   TestAccAWSIAMRolePolicy_importBasic
=== PAUSE TestAccAWSIAMRolePolicy_importBasic
=== RUN   TestAccAWSIAMRolePolicy_basic
=== PAUSE TestAccAWSIAMRolePolicy_basic
=== RUN   TestAccAWSIAMRolePolicy_namePrefix
=== PAUSE TestAccAWSIAMRolePolicy_namePrefix
=== RUN   TestAccAWSIAMRolePolicy_generatedName
=== PAUSE TestAccAWSIAMRolePolicy_generatedName
=== RUN   TestAccAWSIAMRolePolicy_invalidJSON
=== PAUSE TestAccAWSIAMRolePolicy_invalidJSON
=== CONT  TestAccAWSIAMRolePolicy_importBasic
=== CONT  TestAccAWSIAMRolePolicy_generatedName
=== CONT  TestAccAWSIAMRolePolicy_namePrefix
=== CONT  TestAccAWSIAMRolePolicy_basic
=== CONT  TestAccAWSIAMRolePolicy_invalidJSON
--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (3.39s)
--- PASS: TestAccAWSIAMRolePolicy_importBasic (56.54s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (74.13s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (74.94s)
--- PASS: TestAccAWSIAMRolePolicy_basic (77.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws
...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 30, 2018
@bflad bflad added the bug Addresses a defect in current functionality. label Oct 30, 2018
@bflad bflad added this to the v1.42.0 milestone Oct 30, 2018
bflad
bflad approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @saravanan30erd!! 🚀

--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (0.74s)
--- PASS: TestAccAWSIAMRolePolicy_importBasic (8.66s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (12.59s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (12.91s)
--- PASS: TestAccAWSIAMRolePolicy_basic (12.97s)

@bflad bflad merged commit 680cbb0 into hashicorp:master Oct 30, 2018
bflad added a commit that referenced this pull request Oct 30, 2018
@bflad
Update CHANGELOG for #6304
7f93f3c
@saravanan30erd saravanan30erd deleted the issue-6144 branch October 30, 2018 19:47
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.

Resource 'aws_iam_role_policy.example_policy' does not have attribute 'name'
2 participants
@saravanan30erd @bflad