Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ebs_volume: Switch to tagging on creation, update acceptance testing #6396

Merged
merged 2 commits into from
Nov 12, 2018
Merged

resource/aws_ebs_volume: Switch to tagging on creation, update acceptance testing #6396

merged 2 commits into from
Nov 12, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 8, 2018

Closes #1533
Closes #4428

Changes proposed in this pull request:

  • resource/aws_ebs_volume: Set tags on creation
  • tests/resource/aws_ebs_volume: Consolidate import test, enhance basic test, and refactor for current practices

Output from acceptance testing:

--- PASS: TestAccAWSEBSVolume_basic (23.19s)
--- PASS: TestAccAWSEBSVolume_withTags (23.28s)
--- PASS: TestAccAWSEBSVolume_NoIops (23.31s)
--- PASS: TestAccAWSEBSVolume_updateIops (43.79s)
--- PASS: TestAccAWSEBSVolume_updateType (43.95s)
--- PASS: TestAccAWSEBSVolume_updateSize (44.21s)
--- PASS: TestAccAWSEBSVolume_kmsKey (52.88s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (167.64s)

@bflad
resource/aws_ebs_volume: Set tags on creation
3d44f91 
```
--- PASS: TestAccAWSEBSVolume_basic (23.19s)
--- PASS: TestAccAWSEBSVolume_withTags (23.28s)
--- PASS: TestAccAWSEBSVolume_NoIops (23.31s)
--- PASS: TestAccAWSEBSVolume_updateIops (43.79s)
--- PASS: TestAccAWSEBSVolume_updateType (43.95s)
--- PASS: TestAccAWSEBSVolume_updateSize (44.21s)
--- PASS: TestAccAWSEBSVolume_kmsKey (52.88s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (167.64s)
```
@bflad
tests/resource/aws_ebs_volume: Consolidate import test, enhance basic…
d0ea6e0 
… test, and refactor for current practices

```
--- PASS: TestAccAWSEBSVolume_basic (23.19s)
--- PASS: TestAccAWSEBSVolume_withTags (23.28s)
--- PASS: TestAccAWSEBSVolume_NoIops (23.31s)
--- PASS: TestAccAWSEBSVolume_updateIops (43.79s)
--- PASS: TestAccAWSEBSVolume_updateType (43.95s)
--- PASS: TestAccAWSEBSVolume_updateSize (44.21s)
--- PASS: TestAccAWSEBSVolume_kmsKey (52.88s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (167.64s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Nov 8, 2018
@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 8, 2018
@bflad bflad requested a review from a team November 12, 2018 14:59
mbfrahry
mbfrahry approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v1.44.0 milestone Nov 12, 2018
@bflad bflad merged commit 16a8189 into master Nov 12, 2018
@bflad bflad deleted the f-aws_ebs_volume-tag-on-create branch November 12, 2018 17:02
bflad added a commit that referenced this pull request Nov 12, 2018
@bflad
Update CHANGELOG for #6396
fcf1069
@bflad
Copy link
Contributor Author

bflad commented Nov 15, 2018

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@wedge-jarrad wedge-jarrad mentioned this pull request Sep 2, 2019
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.44.0
2 participants
@bflad @mbfrahry