Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/codebuild: Enable Bitbucket Report Build Status and Document Bitbucket Webhooks #6426

Merged
merged 3 commits into from
Nov 12, 2018
Merged

service/codebuild: Enable Bitbucket Report Build Status and Document Bitbucket Webhooks #6426

merged 3 commits into from
Nov 12, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 11, 2018

Closes #6296

Changes proposed in this pull request:

  • resource/aws_codebuild_project: Support source report_build_status for Bitbucket
  • resource/aws_codebuild_webhook: Test and document Bitbucket support

Output from acceptance testing:

--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (31.71s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (19.70s)
--- PASS: TestAccAWSCodeBuildProject_basic (20.21s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (26.73s)
--- PASS: TestAccAWSCodeBuildProject_Cache (50.39s)
--- PASS: TestAccAWSCodeBuildProject_Description (30.49s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (47.71s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (32.76s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (28.80s)
--- PASS: TestAccAWSCodeBuildProject_importBasic (22.80s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (31.29s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (32.24s)
--- PASS: TestAccAWSCodeBuildProject_Source_Auth (32.05s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (30.16s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (29.03s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (36.98s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (37.17s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (22.15s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (28.85s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (28.08s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (22.01s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (22.26s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (8.84s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (22.34s)
--- PASS: TestAccAWSCodeBuildProject_Tags (39.12s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (55.53s)
--- PASS: TestAccAWSCodeBuildWebhook_Bitbucket (36.75s)
--- PASS: TestAccAWSCodeBuildWebhook_BranchFilter (35.13s)
--- PASS: TestAccAWSCodeBuildWebhook_GitHub (26.14s)
--- PASS: TestAccAWSCodeBuildWebhook_GitHubEnterprise (36.14s)

@bflad
resource/aws_codebuild_project: Support source `report_build_status…
0ebfc48 
…` for Bitbucket

```
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (31.71s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (19.70s)
--- PASS: TestAccAWSCodeBuildProject_basic (20.21s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (26.73s)
--- PASS: TestAccAWSCodeBuildProject_Cache (50.39s)
--- PASS: TestAccAWSCodeBuildProject_Description (30.49s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (47.71s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (32.76s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (28.80s)
--- PASS: TestAccAWSCodeBuildProject_importBasic (22.80s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (31.29s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (32.24s)
--- PASS: TestAccAWSCodeBuildProject_Source_Auth (32.05s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (30.16s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (29.03s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (36.98s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (37.17s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (22.15s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (28.85s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (28.08s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (22.01s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (22.26s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (8.84s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (22.34s)
--- PASS: TestAccAWSCodeBuildProject_Tags (39.12s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (55.53s)
```
@bflad
resource/aws_codebuild_webhook: Test and document Bitbucket support
deb3386 
```
--- PASS: TestAccAWSCodeBuildWebhook_Bitbucket (36.75s)
--- PASS: TestAccAWSCodeBuildWebhook_BranchFilter (35.13s)
--- PASS: TestAccAWSCodeBuildWebhook_GitHub (26.14s)
--- PASS: TestAccAWSCodeBuildWebhook_GitHubEnterprise (36.14s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. labels Nov 11, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 11, 2018
@bflad
tests/resource/aws_codebuild_project: Adjust copypasta for testAccAWS…
44aa119 
…CodeBuildBitbucketSourceLocationFromEnv comment
@bflad bflad mentioned this pull request Nov 11, 2018
Closed
@bflad bflad requested a review from a team November 12, 2018 13:53
mbfrahry
mbfrahry approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v1.44.0 milestone Nov 12, 2018
@bflad bflad merged commit cfe0e7a into master Nov 12, 2018
@bflad bflad deleted the f-aws_codebuild_project-bitbucket-reportbuildstatus branch November 12, 2018 14:55
bflad added a commit that referenced this pull request Nov 12, 2018
@bflad
Update CHANGELOG for #6426
c656e70
@bflad
Copy link
Contributor Author

bflad commented Nov 15, 2018

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@gthole gthole mentioned this pull request Dec 19, 2018
Merged
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.44.0
Development

Successfully merging this pull request may close these issues.

Add Report Build Status Argument to CodeBuild Project Resource for Bitbucket
2 participants
@bflad @mbfrahry