API Gateway deployment resource, field stage_name not required #2918

[sousmangoosta]

Fixes #2918

Changes proposed in this pull request:

• Field stage_name changed from required to optional

[bflad]

Hi @sousmangoosta 👋 Thanks for submitting this! Would you be able to include a new acceptance test and test configuration that covers not setting this argument?

[sousmangoosta]

Hi @bflad , I'll try doing that, I found a bug for this change.
When I change from stage for example "default" to no one, the plan create a map like that :
"stage_name":*terraform.ResourceAttrDiff{Old:"default", New:"", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:true, Sensitive:false, Type:0x0}

But on apply, the map does not contain stage_name, so terraform complaints with Mismatch reason: attribute mismatch: stage_name

[sousmangoosta]

Hey @bflad, I don't have this bug anymore, so I will add new acceptance test, and push when ready.

[sousmangoosta]

@bflad acceptance tests has been added.

make testacc TESTARGS='-run=TestAccAWSAPIGatewayDeployment' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAPIGatewayDeployment -timeout 120m ? github.com/terraform-providers/terraform-provider-aws [no test files] === RUN TestAccAWSAPIGatewayDeployment_basic === PAUSE TestAccAWSAPIGatewayDeployment_basic === RUN TestAccAWSAPIGatewayDeployment_basicEmptyStage === PAUSE TestAccAWSAPIGatewayDeployment_basicEmptyStage === RUN TestAccAWSAPIGatewayDeployment_namedToEmptyStage === PAUSE TestAccAWSAPIGatewayDeployment_namedToEmptyStage === RUN TestAccAWSAPIGatewayDeployment_createBeforeDestoryUpdate === PAUSE TestAccAWSAPIGatewayDeployment_createBeforeDestoryUpdate === CONT TestAccAWSAPIGatewayDeployment_basic === CONT TestAccAWSAPIGatewayDeployment_createBeforeDestoryUpdate === CONT TestAccAWSAPIGatewayDeployment_namedToEmptyStage === CONT TestAccAWSAPIGatewayDeployment_basicEmptyStage --- PASS: TestAccAWSAPIGatewayDeployment_basic (33.58s) --- PASS: TestAccAWSAPIGatewayDeployment_namedToEmptyStage (66.86s) --- PASS: TestAccAWSAPIGatewayDeployment_basicEmptyStage (102.53s) --- PASS: TestAccAWSAPIGatewayDeployment_createBeforeDestoryUpdate (159.43s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 159.467s

[sousmangoosta]

@bflad : Is there someone to review this one ?

[anthonyagresta]

Commenting to bump this PR, ran into this issue today.

[mkirlin]

Just wanted to put another bump in here. I'm working around this with an apply-import-apply chain of commands, but it would be nice to have this actually optional as displayed in the docs.

[jpadhye]

Hit this issue at work. Giving a bump

[simsinght]

also running into this issue. bump.

[jvanwagner]

@bflad @nywilken @mikecook any progress on possibly reviewing/approving this? We just hit this issue at our company and seems like a lot of others ran across it as well.

[bflad]

Hi @sousmangoosta 👋 Thanks for this contribution and sorry for the delay. After refactoring the testing changes to match the newer testing on master, acceptance testing passes.

--- PASS: TestAccAWSAPIGatewayDeployment_StageName_EmptyString (20.75s)
--- PASS: TestAccAWSAPIGatewayDeployment_Description (55.58s)
--- PASS: TestAccAWSAPIGatewayDeployment_createBeforeDestoryUpdate (56.30s)
--- PASS: TestAccAWSAPIGatewayDeployment_Variables (117.39s)
--- PASS: TestAccAWSAPIGatewayDeployment_StageName (138.02s)
--- PASS: TestAccAWSAPIGatewayDeployment_StageDescription (201.81s)
--- PASS: TestAccAWSAPIGatewayDeployment_basic (211.81s)

[bflad]

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!