Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/ecs_service: add propagate_tags attribute #6603

Merged
merged 2 commits into from
Dec 5, 2018
Merged

r/ecs_service: add propagate_tags attribute #6603

merged 2 commits into from
Dec 5, 2018

Conversation

kl4w
Copy link
Contributor

@kl4w kl4w commented Nov 27, 2018

Fixes #6601

Changes proposed in this pull request:

  • add propagate_tags attribute

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSEcsService_ -timeout 120m
=== RUN   TestAccAWSEcsService_withARN
=== PAUSE TestAccAWSEcsService_withARN
=== RUN   TestAccAWSEcsService_basicImport
=== PAUSE TestAccAWSEcsService_basicImport
=== RUN   TestAccAWSEcsService_disappears
=== PAUSE TestAccAWSEcsService_disappears
=== RUN   TestAccAWSEcsService_withUnnormalizedPlacementStrategy
=== PAUSE TestAccAWSEcsService_withUnnormalizedPlacementStrategy
=== RUN   TestAccAWSEcsService_withFamilyAndRevision
=== PAUSE TestAccAWSEcsService_withFamilyAndRevision
=== RUN   TestAccAWSEcsService_withRenamedCluster
=== PAUSE TestAccAWSEcsService_withRenamedCluster
=== RUN   TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== PAUSE TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== RUN   TestAccAWSEcsService_withIamRole
=== PAUSE TestAccAWSEcsService_withIamRole
=== RUN   TestAccAWSEcsService_withDeploymentValues
=== PAUSE TestAccAWSEcsService_withDeploymentValues
=== RUN   TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred
=== PAUSE TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred
=== RUN   TestAccAWSEcsService_withLbChanges
=== PAUSE TestAccAWSEcsService_withLbChanges
=== RUN   TestAccAWSEcsService_withEcsClusterName
=== PAUSE TestAccAWSEcsService_withEcsClusterName
=== RUN   TestAccAWSEcsService_withAlb
=== PAUSE TestAccAWSEcsService_withAlb
=== RUN   TestAccAWSEcsService_withPlacementStrategy
=== PAUSE TestAccAWSEcsService_withPlacementStrategy
=== RUN   TestAccAWSEcsService_withPlacementConstraints
=== PAUSE TestAccAWSEcsService_withPlacementConstraints
=== RUN   TestAccAWSEcsService_withPlacementConstraints_emptyExpression
=== PAUSE TestAccAWSEcsService_withPlacementConstraints_emptyExpression
=== RUN   TestAccAWSEcsService_withLaunchTypeFargate
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (219.74s)
=== RUN   TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration
=== PAUSE TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration
=== RUN   TestAccAWSEcsService_withDaemonSchedulingStrategy
=== PAUSE TestAccAWSEcsService_withDaemonSchedulingStrategy
=== RUN   TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum
=== PAUSE TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum
=== RUN   TestAccAWSEcsService_withReplicaSchedulingStrategy
=== PAUSE TestAccAWSEcsService_withReplicaSchedulingStrategy
=== RUN   TestAccAWSEcsService_withServiceRegistries
=== PAUSE TestAccAWSEcsService_withServiceRegistries
=== RUN   TestAccAWSEcsService_withServiceRegistries_container
=== PAUSE TestAccAWSEcsService_withServiceRegistries_container
=== RUN   TestAccAWSEcsService_Tags
=== PAUSE TestAccAWSEcsService_Tags
=== RUN   TestAccAWSEcsService_ManagedTags
=== PAUSE TestAccAWSEcsService_ManagedTags
=== CONT  TestAccAWSEcsService_withARN
=== CONT  TestAccAWSEcsService_withPlacementStrategy
=== CONT  TestAccAWSEcsService_withReplicaSchedulingStrategy
=== CONT  TestAccAWSEcsService_withDaemonSchedulingStrategy
=== CONT  TestAccAWSEcsService_withEcsClusterName
=== CONT  TestAccAWSEcsService_withIamRole
=== CONT  TestAccAWSEcsService_Tags
=== CONT  TestAccAWSEcsService_withServiceRegistries_container
=== CONT  TestAccAWSEcsService_withAlb
=== CONT  TestAccAWSEcsService_withFamilyAndRevision
=== CONT  TestAccAWSEcsService_ManagedTags
=== CONT  TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== CONT  TestAccAWSEcsService_withRenamedCluster
=== CONT  TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum
=== CONT  TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration
=== CONT  TestAccAWSEcsService_withPlacementConstraints_emptyExpression
=== CONT  TestAccAWSEcsService_withDeploymentValues
=== CONT  TestAccAWSEcsService_withPlacementConstraints
=== CONT  TestAccAWSEcsService_withLbChanges
=== CONT  TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (24.06s)
=== CONT  TestAccAWSEcsService_disappears
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (31.84s)
=== CONT  TestAccAWSEcsService_withUnnormalizedPlacementStrategy
--- PASS: TestAccAWSEcsService_withEcsClusterName (32.10s)
=== CONT  TestAccAWSEcsService_withServiceRegistries
--- PASS: TestAccAWSEcsService_withARN (32.49s)
=== CONT  TestAccAWSEcsService_basicImport
--- PASS: TestAccAWSEcsService_Tags (36.98s)
--- PASS: TestAccAWSEcsService_disappears (14.85s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (39.27s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (42.09s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (42.55s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (42.72s)
--- PASS: TestAccAWSEcsService_ManagedTags (42.75s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (42.79s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (43.00s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (15.51s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (59.43s)
--- PASS: TestAccAWSEcsService_basicImport (33.39s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (95.08s)
--- PASS: TestAccAWSEcsService_withIamRole (121.84s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (162.22s)
--- PASS: TestAccAWSEcsService_withLbChanges (236.45s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (251.39s)
--- PASS: TestAccAWSEcsService_withAlb (255.85s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (244.20s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (330.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	550.678s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 27, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 27, 2018
bflad
bflad reviewed Dec 5, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little changes and I think this will be good to go. Thanks, @kl4w! 🚀

aws/resource_aws_ecs_service.go Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 5, 2018
@kl4w kl4w force-pushed the ecs-service-propagate-tags branch from 956a27e to 343ddaf Compare December 5, 2018 11:34
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 5, 2018
@kl4w
Copy link
Contributor Author

kl4w commented Dec 5, 2018 •
edited
Loading 

make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSEcsService_ -timeout 120m
=== RUN   TestAccAWSEcsService_withARN
=== PAUSE TestAccAWSEcsService_withARN
=== RUN   TestAccAWSEcsService_basicImport
=== PAUSE TestAccAWSEcsService_basicImport
=== RUN   TestAccAWSEcsService_disappears
=== PAUSE TestAccAWSEcsService_disappears
=== RUN   TestAccAWSEcsService_withUnnormalizedPlacementStrategy
=== PAUSE TestAccAWSEcsService_withUnnormalizedPlacementStrategy
=== RUN   TestAccAWSEcsService_withFamilyAndRevision
=== PAUSE TestAccAWSEcsService_withFamilyAndRevision
=== RUN   TestAccAWSEcsService_withRenamedCluster
=== PAUSE TestAccAWSEcsService_withRenamedCluster
=== RUN   TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== PAUSE TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== RUN   TestAccAWSEcsService_withIamRole
=== PAUSE TestAccAWSEcsService_withIamRole
=== RUN   TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== PAUSE TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== RUN   TestAccAWSEcsService_withDeploymentValues
=== PAUSE TestAccAWSEcsService_withDeploymentValues
=== RUN   TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred
=== PAUSE TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred
=== RUN   TestAccAWSEcsService_withLbChanges
=== PAUSE TestAccAWSEcsService_withLbChanges
=== RUN   TestAccAWSEcsService_withEcsClusterName
=== PAUSE TestAccAWSEcsService_withEcsClusterName
=== RUN   TestAccAWSEcsService_withAlb
=== PAUSE TestAccAWSEcsService_withAlb
=== RUN   TestAccAWSEcsService_withPlacementStrategy
=== PAUSE TestAccAWSEcsService_withPlacementStrategy
=== RUN   TestAccAWSEcsService_withPlacementConstraints
=== PAUSE TestAccAWSEcsService_withPlacementConstraints
=== RUN   TestAccAWSEcsService_withPlacementConstraints_emptyExpression
=== PAUSE TestAccAWSEcsService_withPlacementConstraints_emptyExpression
=== RUN   TestAccAWSEcsService_withLaunchTypeFargate
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (308.15s)
=== RUN   TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration
=== PAUSE TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration
=== RUN   TestAccAWSEcsService_withDaemonSchedulingStrategy
=== PAUSE TestAccAWSEcsService_withDaemonSchedulingStrategy
=== RUN   TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum
=== PAUSE TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum
=== RUN   TestAccAWSEcsService_withReplicaSchedulingStrategy
=== PAUSE TestAccAWSEcsService_withReplicaSchedulingStrategy
=== RUN   TestAccAWSEcsService_withServiceRegistries
=== PAUSE TestAccAWSEcsService_withServiceRegistries
=== RUN   TestAccAWSEcsService_withServiceRegistries_container
=== PAUSE TestAccAWSEcsService_withServiceRegistries_container
=== RUN   TestAccAWSEcsService_Tags
=== PAUSE TestAccAWSEcsService_Tags
=== RUN   TestAccAWSEcsService_ManagedTags
=== PAUSE TestAccAWSEcsService_ManagedTags
=== RUN   TestAccAWSEcsService_PropagateTags
=== PAUSE TestAccAWSEcsService_PropagateTags
=== CONT  TestAccAWSEcsService_withARN
=== CONT  TestAccAWSEcsService_withPlacementStrategy
=== CONT  TestAccAWSEcsService_withServiceRegistries
=== CONT  TestAccAWSEcsService_ManagedTags
=== CONT  TestAccAWSEcsService_PropagateTags
=== CONT  TestAccAWSEcsService_withServiceRegistries_container
=== CONT  TestAccAWSEcsService_withIamRole
=== CONT  TestAccAWSEcsService_withLbChanges
=== CONT  TestAccAWSEcsService_basicImport
=== CONT  TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum
=== CONT  TestAccAWSEcsService_withFamilyAndRevision
=== CONT  TestAccAWSEcsService_withReplicaSchedulingStrategy
=== CONT  TestAccAWSEcsService_withDaemonSchedulingStrategy
=== CONT  TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration
=== CONT  TestAccAWSEcsService_withPlacementConstraints_emptyExpression
=== CONT  TestAccAWSEcsService_withPlacementConstraints
=== CONT  TestAccAWSEcsService_Tags
=== CONT  TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== CONT  TestAccAWSEcsService_disappears
=== CONT  TestAccAWSEcsService_withUnnormalizedPlacementStrategy
--- PASS: TestAccAWSEcsService_ManagedTags (30.73s)
=== CONT  TestAccAWSEcsService_withRenamedCluster
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (38.95s)
=== CONT  TestAccAWSEcsService_withDeploymentValues
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (39.62s)
=== CONT  TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred
--- PASS: TestAccAWSEcsService_basicImport (43.10s)
=== CONT  TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
--- PASS: TestAccAWSEcsService_disappears (47.33s)
=== CONT  TestAccAWSEcsService_withAlb
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (49.46s)
=== CONT  TestAccAWSEcsService_withEcsClusterName
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (49.93s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (50.00s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (50.01s)
--- PASS: TestAccAWSEcsService_withARN (52.52s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (54.15s)
--- PASS: TestAccAWSEcsService_Tags (67.82s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (38.80s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (39.01s)
--- PASS: TestAccAWSEcsService_PropagateTags (95.52s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (95.60s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (49.99s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (74.39s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (137.14s)
--- PASS: TestAccAWSEcsService_withIamRole (185.74s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (219.63s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (220.50s)
--- PASS: TestAccAWSEcsService_withAlb (226.65s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (286.77s)
--- PASS: TestAccAWSEcsService_withLbChanges (334.27s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (291.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	642.877s

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 5, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 5, 2018
bflad
bflad approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @kl4w! 🚀

--- PASS: TestAccAWSEcsService_basicImport (42.88s)
--- PASS: TestAccAWSEcsService_disappears (20.13s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (282.03s)
--- PASS: TestAccAWSEcsService_ManagedTags (40.92s)
--- PASS: TestAccAWSEcsService_PropagateTags (87.42s)
--- PASS: TestAccAWSEcsService_Tags (35.42s)
--- PASS: TestAccAWSEcsService_withAlb (240.43s)
--- PASS: TestAccAWSEcsService_withARN (37.93s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (17.38s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (17.13s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (228.64s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (40.44s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (29.04s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (15.05s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (36.26s)
--- PASS: TestAccAWSEcsService_withIamRole (168.44s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (86.32s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (266.31s)
--- PASS: TestAccAWSEcsService_withLbChanges (256.72s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (24.70s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (51.36s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (148.85s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (58.72s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (40.84s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (201.65s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (201.36s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (16.18s)

@bflad bflad merged commit fb5a1be into hashicorp:master Dec 5, 2018
bflad added a commit that referenced this pull request Dec 5, 2018
@bflad
Update CHANGELOG for #6603
e6de025
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@kl4w kl4w deleted the ecs-service-propagate-tags branch December 6, 2018 11:45
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.51.0
Development

Successfully merging this pull request may close these issues.

r/ecs_service: add propagate_tags attribute
2 participants
@kl4w @bflad