Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicate sid in policy document #6675

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

sunilkumarmohanty
Copy link
Contributor

Fixes #6659

Changes proposed in this pull request:

  • Checks for duplicate SID

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. labels Dec 1, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 1, 2018
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 2, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 3, 2018
@sunilkumarmohanty
Copy link
Contributor Author

Added Acceptance test

 make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMPolicyDocument_duplicateSid'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDataSourceIAMPolicyDocument_duplicateSid -timeout 120m
=== RUN   TestAccAWSDataSourceIAMPolicyDocument_duplicateSid
=== PAUSE TestAccAWSDataSourceIAMPolicyDocument_duplicateSid
=== CONT  TestAccAWSDataSourceIAMPolicyDocument_duplicateSid
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_duplicateSid (23.93s)
PASS
ok      github.com/sunilkumarmohanty/terraform-provider-aws/aws (cached)

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 3, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 3, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sunilkumarmohanty! 🚀

--- PASS: TestAccAWSDataSourceIAMPolicyDocument_override (4.02s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementOverride (4.13s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceConflicting (4.21s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementMerge (4.22s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_basic (4.26s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_duplicateSid (4.38s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_source (6.39s)

@bflad bflad merged commit 54a2e1c into hashicorp:master Dec 3, 2018
bflad added a commit that referenced this pull request Dec 3, 2018
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate sid in policy causes unexpected behavior
2 participants