Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F addlambda provided #6676

Merged
merged 3 commits into from
Dec 1, 2018
Merged

F addlambda provided #6676

merged 3 commits into from
Dec 1, 2018

Conversation

kikitux
Copy link
Contributor

@kikitux kikitux commented Dec 1, 2018

Implement runtime provided in aws lambda

https://docs.aws.amazon.com/lambda/latest/dg/API_CreateFunction.html#API_CreateFunction_RequestSyntax

Runtime
The runtime version for the function.

Type: String

Valid Values: nodejs | nodejs4.3 | nodejs6.10 | nodejs8.10 | java8 | python2.7 | python3.6 | python3.7 | dotnetcore1.0 | dotnetcore2.0 | dotnetcore2.1 | nodejs4.3-edge | go1.x | ruby2.5 | provided

Required: Yes

Changes proposed in this pull request:

  • Add test func TestAccAWSLambdaFunction_runtimeValidation_provided()
  • Add test func testAccAWSLambdaConfigProvidedRuntime()
  • Add lambda.RuntimeProvided as valid runtime to func resourceAwsLambdaFunction()

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction_runtimeValidation_provided'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSLambdaFunction_runtimeValidation_provided -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_provided
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_provided
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_provided
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (40.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.435s

Thanks!
alvaro.

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 1, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 1, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 1, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much @kikitux! 🚀

--- PASS: TestAccAWSLambdaFunction_importS3 (18.79s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (18.97s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (20.89s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile_VPC (27.54s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile (32.77s)
--- PASS: TestAccAWSLambdaFunction_versioned (34.09s)
--- PASS: TestAccAWSLambdaFunction_basic (45.85s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (0.46s)
--- PASS: TestAccAWSLambdaFunction_s3 (27.29s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (49.03s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (50.41s)
--- PASS: TestAccAWSLambdaFunction_VPC (51.92s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (34.78s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (29.80s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (65.22s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (65.36s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (70.72s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (38.28s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (76.26s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (76.32s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (79.57s)
--- PASS: TestAccAWSLambdaFunction_concurrency (81.24s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_nodeJs43 (36.25s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (82.76s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (29.10s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (34.43s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (55.56s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (43.63s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (89.91s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (41.10s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (33.37s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (27.56s)
--- PASS: TestAccAWSLambdaFunction_envVariables (94.30s)
--- PASS: TestAccAWSLambdaFunction_tags (45.16s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (92.83s)

@bflad bflad merged commit 33c67b9 into hashicorp:master Dec 1, 2018
bflad added a commit that referenced this pull request Dec 1, 2018
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants