Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new resource for changed aws_iam_user_ssh_key public_key and encoding #6718

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

AMeng
Copy link
Contributor

@AMeng AMeng commented Dec 4, 2018

Fixes #378

Changes proposed in this pull request:

  • Create a new aws_iam_user_ssh_key resource when either public_key or encoding changes.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSUserSSHKey'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSUserSSHKey -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSUserSSHKey_basic
=== PAUSE TestAccAWSUserSSHKey_basic
=== RUN   TestAccAWSUserSSHKey_pemEncoding
=== PAUSE TestAccAWSUserSSHKey_pemEncoding
=== CONT  TestAccAWSUserSSHKey_basic
=== CONT  TestAccAWSUserSSHKey_pemEncoding
--- PASS: TestAccAWSUserSSHKey_pemEncoding (13.64s)
--- PASS: TestAccAWSUserSSHKey_basic (15.12s)
PASS

According to the AWS API docs, you cannot edit public_key or encoding. Therefore Terraform should create a new resource.

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. labels Dec 4, 2018
@bflad bflad added the bug Addresses a defect in current functionality. label Dec 5, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much @AMeng! 🚀

--- PASS: TestAccAWSUserSSHKey_basic (9.22s)
--- PASS: TestAccAWSUserSSHKey_pemEncoding (9.74s)

@bflad bflad added this to the v1.51.0 milestone Dec 5, 2018
@bflad bflad merged commit efe63a4 into hashicorp:master Dec 5, 2018
bflad added a commit that referenced this pull request Dec 5, 2018
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_iam_user_ssh_key incorrectly reports updating of the key value
2 participants