Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_ip_ranges: Add url argument #6756

Merged
merged 1 commit into from
Dec 7, 2018
Merged

data-source/aws_ip_ranges: Add url argument #6756

merged 1 commit into from
Dec 7, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 7, 2018

The original hardcoded URL (https://ip-ranges.amazonaws.com/ip-ranges.json) is only for the AWS Commercial partition. Other AWS partitions have privately available IP Range JSON files at known URLs.

Output from acceptance testing:

--- PASS: TestAccAWSIPRanges_basic (9.89s)
--- PASS: TestAccAWSIPRanges_Url (10.13s)

@bflad
data-source/aws_ip_ranges: Add url argument
6ddd93c 
The original hardcoded URL (https://ip-ranges.amazonaws.com/ip-ranges.json) is only for the AWS Commercial partition. Other AWS partitions have privately available IP Range JSON files at known URLs.

Output from acceptance testing:

```
--- PASS: TestAccAWSIPRanges_basic (9.89s)
--- PASS: TestAccAWSIPRanges_Url (10.13s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. labels Dec 7, 2018
@bflad bflad requested a review from a team December 7, 2018 07:34
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 7, 2018
mbfrahry
mbfrahry approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v1.52.0 milestone Dec 7, 2018
@bflad bflad merged commit f55ffc6 into master Dec 7, 2018
@bflad bflad deleted the f-aws_ip_ranges-url branch December 7, 2018 18:51
bflad added a commit that referenced this pull request Dec 7, 2018
@bflad
Update CHANGELOG for #6756
69cdf3f
@bflad
Copy link
Contributor Author

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @mbfrahry