Do not throw error when lambda permission is deleted after function #6770
Conversation
ghost
added
size/XS
Puneeth-n
changed the title
| @@ -301,6 +301,13 @@ func resourceAwsLambdaPermissionDelete(d *schema.ResourceData, meta interface{}) | |||
| log.Printf("[DEBUG] Removing Lambda permission: %s", input) | |||
| _, err := conn.RemovePermission(&input) | |||
| if err != nil { | |||
| // Missing whole policy or Lambda function (API error) | |||
| if awsErr, ok := err.(awserr.Error); ok { | |||
| if awsErr.Code() == "ResourceNotFoundException" { | |||
There was a problem hiding this comment.
Nit: We prefer to use our helper function to determine these and use the SDK provided constants:
if isAWSErr(err, lambda.ErrCodeResourceNotFoundException, "") {| // Missing whole policy or Lambda function (API error) | ||
| if awsErr, ok := err.(awserr.Error); ok { | ||
| if awsErr.Code() == "ResourceNotFoundException" { | ||
| log.Printf("[WARN] No Lambda Permission Policy found: %v", input) |
There was a problem hiding this comment.
Nit: We prefer to skip logging that an API object is missing when Terraform is already trying to delete it.
There was a problem hiding this comment.
@bflad Thanks for the heads up. Will remember it :)
|
This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #6769