Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_eks_cluster: Support version update #6843

Merged
merged 1 commit into from
Dec 13, 2018
Merged

resource/aws_eks_cluster: Support version update #6843

merged 1 commit into from
Dec 13, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 13, 2018 •
edited
Loading

Changes proposed in this pull request:

  • On the tin

Output from acceptance testing:

--- PASS: TestAccAWSEksCluster_basic (1088.52s)
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1142.70s)
--- PASS: TestAccAWSEksCluster_Version (2447.04s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. labels Dec 13, 2018
@bflad bflad added this to the v1.52.0 milestone Dec 13, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 13, 2018
@bflad
Copy link
Contributor Author

bflad commented Dec 13, 2018

This code was previously reviewed and all tests are green, merging! 🚀

@bflad bflad merged commit 5a8dcde into master Dec 13, 2018
@bflad bflad deleted the f-eks-update-cluster-version branch December 13, 2018 11:38
bflad added a commit that referenced this pull request Dec 13, 2018
@bflad
Update CHANGELOG for #6843
4206995
@bflad
Copy link
Contributor Author

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit mentioned this pull request Dec 18, 2018
Closed
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.
1 participant
@bflad