Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_s3_bucket: Skip MethodNotAllowed error for missing S3 Bucket Acceleration functionality (eu-north-1 support) #6873

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 17, 2018

Closes #6853

Previously (in eu-north-1 region):

--- FAIL: TestAccAWSS3Bucket_basic (12.73s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_s3_bucket.bucket: 1 error occurred:
        	* aws_s3_bucket.bucket: error getting S3 Bucket acceleration configuration: MethodNotAllowed: The specified method is not allowed against this resource.
        	status code: 405, request id: C4FF2A8370BED40B, host id: 7N8DyRUtrgpFbAJAzpbdG0DjGRVoESdOcy+T9Jf2yxiKlTDUUSydC1YpqxZXdqBlz6XaMgsUDA4=

Output from acceptance testing (in eu-north-1 region):

--- PASS: TestAccAWSS3Bucket_basic (29.97s)

…cket Acceleration functionality (eu-north-1 support)

Previously (in eu-north-1 region):

```
--- FAIL: TestAccAWSS3Bucket_basic (12.73s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_s3_bucket.bucket: 1 error occurred:
        	* aws_s3_bucket.bucket: error getting S3 Bucket acceleration configuration: MethodNotAllowed: The specified method is not allowed against this resource.
        	status code: 405, request id: C4FF2A8370BED40B, host id: 7N8DyRUtrgpFbAJAzpbdG0DjGRVoESdOcy+T9Jf2yxiKlTDUUSydC1YpqxZXdqBlz6XaMgsUDA4=
```

Output from acceptance testing (in eu-north-1 region):

```
--- PASS: TestAccAWSS3Bucket_basic (29.97s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/s3 Issues and PRs that pertain to the s3 service. labels Dec 17, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Dec 17, 2018
@bflad bflad requested a review from a team December 18, 2018 15:55
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bflad bflad added this to the v1.53.0 milestone Dec 19, 2018
@bflad bflad merged commit 25b4e92 into master Dec 19, 2018
@bflad bflad deleted the b-aws_s3_bucket-get-acceleration-methodnotfound branch December 19, 2018 16:19
bflad added a commit that referenced this pull request Dec 19, 2018
@bflad
Copy link
Contributor Author

bflad commented Dec 20, 2018

This has been released in version 1.53.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 bucket creations fails in eu-north-1 (due to GET /?accelerate= HTTP/1.1 failure)
2 participants