Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_licensemanager: Add aws_licensemanager_association resource #6926

Merged
merged 4 commits into from
Dec 21, 2018
Merged

r/aws_licensemanager: Add aws_licensemanager_association resource #6926

merged 4 commits into from
Dec 21, 2018

Conversation

gazoakley
Copy link
Contributor

Closes #6654

Changes proposed in this pull request:

  • New Resource: aws_licensemanager_association
  • resource/aws_launch_template: Add license_specification argument

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLicenseManagerAssociation_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSLicenseManagerAssociation_basic -timeout 120m
=== RUN   TestAccAWSLicenseManagerAssociation_basic
=== PAUSE TestAccAWSLicenseManagerAssociation_basic
=== CONT  TestAccAWSLicenseManagerAssociation_basic
--- PASS: TestAccAWSLicenseManagerAssociation_basic (140.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	140.116s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLaunchTemplate_licenseSpecification'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSLaunchTemplate_licenseSpecification -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_licenseSpecification
=== PAUSE TestAccAWSLaunchTemplate_licenseSpecification
=== CONT  TestAccAWSLaunchTemplate_licenseSpecification
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (45.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.293s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 19, 2018
@bflad bflad added the new-resource Introduces a new resource. label Dec 19, 2018
bflad
bflad reviewed Dec 19, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial feedback below, thanks @gazoakley!

aws/resource_aws_launch_template.go Outdated Show resolved Hide resolved
aws/resource_aws_licensemanager_association.go Outdated Show resolved Hide resolved
website/docs/r/licensemanager_association.markdown Outdated Show resolved Hide resolved
website/docs/r/licensemanager_association.markdown Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 19, 2018
@gazoakley
Copy link
Contributor Author

Hi @bflad - updated to address review comments 👍

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 21, 2018
@bflad bflad added the service/licensemanager Issues and PRs that pertain to the licensemanager service. label Dec 21, 2018
@bflad bflad added this to the v1.54.0 milestone Dec 21, 2018
bflad
bflad approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀

--- PASS: TestAccAWSLaunchTemplate_disappears (9.61s)
--- PASS: TestAccAWSLaunchTemplate_data (9.76s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (10.36s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (12.16s)
--- PASS: TestAccAWSLaunchTemplate_importData (12.68s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (12.58s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (12.90s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (13.33s)
--- PASS: TestAccAWSLaunchTemplate_importBasic (13.75s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (15.50s)
--- PASS: TestAccAWSLaunchTemplate_tags (15.81s)
--- PASS: TestAccAWSLaunchTemplate_basic (18.13s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (18.14s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (19.31s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (21.56s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (30.47s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (40.88s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (40.99s)
--- PASS: TestAccAWSLaunchTemplate_update (45.82s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (46.29s)
--- PASS: TestAccAWSLicenseManagerAssociation_basic (111.38s)

@bflad bflad merged commit e7dee04 into hashicorp:master Dec 21, 2018
bflad added a commit that referenced this pull request Dec 21, 2018
@bflad
Update CHANGELOG for #6926
f0e0d90
@bflad
Copy link
Contributor

bflad commented Dec 21, 2018

This has been released in version 1.54.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
@gazoakley gazoakley deleted the f-license-manager-association branch April 7, 2020 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/licensemanager Issues and PRs that pertain to the licensemanager service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.54.0
Development

Successfully merging this pull request may close these issues.

Feature Request: License Manager
2 participants
@gazoakley @bflad